fix(gitlawb): replace curl|sh installer with npm install -g @gitlawb/gl#396
Open
antfleet-ops wants to merge 1 commit into
Open
fix(gitlawb): replace curl|sh installer with npm install -g @gitlawb/gl#396antfleet-ops wants to merge 1 commit into
antfleet-ops wants to merge 1 commit into
Conversation
The setup script fetched and executed an arbitrary remote shell script with no checksum or version pin, giving anyone who compromises gitlawb.com or intercepts the connection arbitrary code execution on the installing agent. The SKILL.md already documents the safer npm path; use it instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix — supply-chain attack vector in setup.sh
Severity: HIGH
What's wrong
gitlawb/scripts/setup.shinstalls theglCLI by fetching and executing a remote shell script with no integrity check:curl -sSf https://gitlawb.com/install.sh | shAnyone who can compromise
gitlawb.comor intercept the connection (MITM, CDN compromise) achieves arbitrary code execution on every user or AI agent running the skill. Becausesetup.shis called automatically as part of skill onboarding, the blast radius extends to all downstream consumers.Fix
Replace the
curl | shpattern with the npm install path that is already documented inSKILL.md:npm verifies the package against the registry's cryptographic signatures — no remote shell execution over an unverified channel.
Diff
Found by AntFleet automated security review. Bench PR: AntFleet/bankrskills-bench#3