-
Notifications
You must be signed in to change notification settings - Fork 0
quantamm retroactive fee calc #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| QUANTAMM_POOLS = { | ||
| "mainnet": { | ||
| "0x6b61d8680c4f9e560c8306807908553f95c749c5": 0.50, # non-core with gauge | ||
| "0xd4ed17bbf48af09b87fd7d8c60970f5da79d4852": 0.80, # non-core without gauge | ||
| }, | ||
| "base": { | ||
| "0xb4161aea25bd6c5c8590ad50deb4ca752532f05d": 0.50, # non-core with gauge | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the three quantamm pools i could find with their respective partner fee split. hardcoded them for clarity. should be validated against BIP-871. no quantamm pool has shown up in the core pool list during the retroactive period and the gauge status has not changed for any of them during the retroactive period
pools links:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our code logic. QuantAMM pools without any yield-bearing assets can never become core pools, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
|
test run with quantamm retroactive fees, result is $6,257: #246 (comment) |
5dc5a76 to
3416386
Compare
|
added rocket retroactive fee script. also pushed reports for both quantamm and rocket: |
Xeonus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numbers confirmed by QuantAMM team. Delta shall be deducted from veBAL fee share in the next suitable fee run
solves #233
retroactive fee logic is isolated in the
quantammdir except where its triggered inmain_combined.pyfee run flow now is:
retroactive_fees.py works by:
also contains formatting adjustments to the payload visualizer