Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@gosuto-inzasheru
Copy link
Contributor

@gosuto-inzasheru gosuto-inzasheru commented Jan 27, 2025

closes #336 and closes #289

@gosuto-inzasheru
Copy link
Contributor Author

cron would now only commit to its own branch and skip opening a pr

ran it once manually; see https://github.com/BalancerMaxis/protocol_fee_allocator/tree/collect-fees-cron

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review January 27, 2025 13:04
@gosuto-inzasheru
Copy link
Contributor Author

TODO: close #186 once this is merged

@gosuto-inzasheru
Copy link
Contributor Author

@Xeonus note that this might need your analytics to point to this new branch as well (collect-fees-cron)!

Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, addresses with Xeonus/balancer-analytics#17 in analytics repo

@gosuto-inzasheru gosuto-inzasheru merged commit 1c963b4 into main Jan 28, 2025
4 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the issue/336 branch January 28, 2025 08:34
@gosuto-inzasheru gosuto-inzasheru mentioned this pull request Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: only commit updated core pool json data clean up prs and issues in protocol fee allocator repo

3 participants