This repository was archived by the owner on Jun 17, 2025. It is now read-only.
auto trigger collect fees when mimic fees are merged #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gosuto-inzasheru
left a comment
gosuto-inzasheru
left a comment
There was a problem hiding this comment.
juicy! lets test in prod next week?
gosuto-inzasheru
approved these changes
Jan 24, 2025
Collaborator
Author
|
just remembered: need to copy over the "output_for_msig" csv from v2 as well |
Collaborator
Author
added in deadbee |
gosuto-inzasheru
approved these changes
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #330
depends on BalancerMaxis/protocol_fee_allocator_v2#38 to be merged in order to work so that v2 is aware of merged v1 mimic data