-
Notifications
You must be signed in to change notification settings - Fork 0
replace hh dynamic threshold calc with stakedao version #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| query GetAuraGaugeProposals($first: Int!, $space: String!) { | ||
| proposals ( | ||
| first: $first, | ||
| skip: 0, | ||
| where: { | ||
| space_in: [$space], | ||
| title_contains: "Gauge Weight" | ||
| }, | ||
| orderBy: "created", | ||
| orderDirection: desc | ||
| ) { | ||
| id | ||
| title | ||
| scores_total | ||
| created | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| from decimal import Decimal | ||
| from bal_tools.ecosystem import HiddenHand | ||
| from bal_tools.ecosystem import StakeDAO | ||
|
|
||
|
|
||
| def test_get_min_aura_incentive(): | ||
| hh = HiddenHand() | ||
| result = hh.get_min_aura_incentive() | ||
| def test_calculate_dynamic_min_incentive(): | ||
| sd = StakeDAO() | ||
| result = sd.calculate_dynamic_min_incentive() | ||
|
|
||
| assert isinstance(result, Decimal) | ||
| assert isinstance(result, int) | ||
| assert result > 0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This calculation is not correct IMO
calculate_dynamic_min_incentive does not account for Aura's veBAL share.
Current logic:
min_incentive = max_votes * 0.001 * (1 + buffer_pct) * avg_cpv
This returns the minimum general bribe portion needed. That is wrong. We need to estimate how much of those incentives go to AURA based on AURAs veBAL share
What's needed:
min_aura_portion = max_votes * 0.001 * (1 + buffer_pct) * avg_cpv
min_total_bribe = min_aura_portion / aura_vebal_share
This returns the minimum total bribe so that after the split, Aura's portion still meets the threshold.
Example: if we place $500 combined and if Auras veBAL share is 65%, then the bribes visible to the Aura Votemarket is $500*0.65=$325, so we need to check that the minimum total bribe for both markets leads to be above the minimum threshold for the Aura portion of the combined market.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. ya, threshold needs to be based on the aura portion. fixed in 79a8fed