Modular Plugin Manager#234
Closed
hexiro wants to merge 2 commits intoBaekalfen:masterfrom
Closed
Conversation
Author
|
I see that coincidentally, you opened a PR with a similar goal 2 hours ago. I just opened this because I never finished it and I was organizing my repos (deleting my forks) so I figured I'd open this. If this doesn't get merged that's okay but I hope it can help serve as a reference for what you're doing :) |
Owner
|
Thank you! This is actually really helpful. It's interesting now that we have made two different approaches at the same thing. I think I can steal some of your ideas, and improve mine. I'll be sure to give you a ping and set you as co-author on the commit if I do :) |
Author
|
sounds good! glad it can be of use. |
Owner
|
Closed for inactivity and duplicate of #233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for modularly adding plugins (game wrappers) to PyBoy. This is helpful so users can create their own game wrappers and add them without them having to be officially supported.
There are still some Cython type definition things missing as that's not my specialty, but besides that, I'd like to hear your thoughts.
P.S. my code formatter accidentally added some spaces between plus signs, so if you have an auto code formatter, you might want to run it on this branch.