-
Notifications
You must be signed in to change notification settings - Fork 1
Fix error lint #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix error lint #74
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| class="grid grid-cols-2 md:grid-cols-4 gap-10"> | ||
| <div | ||
| class="relative pb-12 md:col-span-2 text-right space-x-4 justify-self-end md:w-64 mx-2"> | ||
| <div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 == 0" (click)="openModal(item)"> | ||
| <div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 === 0" (click)="openModal(item)" (keydown)="openModal(item)" role="button" aria-disabled="true"> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This keydown handler runs for any key press, so users navigating with keyboard arrows/tab could trigger the modal unintentionally. I’d suggest limiting this to Enter/Space (for example, |
||
| <h3 class=" text-lg md:text-xl font-bold text-primary"> | ||
| {{ item.name }} | ||
| </h3> | ||
|
|
@@ -20,7 +20,8 @@ <h3 class=" text-lg md:text-xl font-bold text-primary"> | |
| <div | ||
| class=" relative md:mx-12 mx-2 pb-12 before:absolute before:left-[-35px] before:block before:h-full before:border-l-2 before:border-black/20 dark:before:border-white/15 before:content-['']"> | ||
| <div class="relative pb-12 space-x-4 md:col-span-2 md:w-64 "> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there is a small template syntax issue here: there is no space between the |
||
| <div class="sticky top-0" *ngIf="i % 2 != 0" (click)="openModal(item)"> | ||
| <div class="sticky top-0" *ngIf="i % 2 !== 0" (click)="openModal(item)" (keydown)="openModal(item)"role="button" | ||
| aria-disabled="true"> | ||
| <span | ||
| class="text-primary -left-[42px] absolute rounded-full text-5xl">•</span> | ||
| <div class="hover:scale-110 duration-700 transition-transform cursor-pointer"> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
aria-disabled="true"conflicts with the current behavior because this element is still clickable and keyboard-actionable. For screen readers this can feel broken, so either removearia-disabledor make the item truly disabled when that attribute is present.