Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ import { Component } from '@angular/core';
styleUrls: ['./app.component.scss'],
})
export class AppComponent {
constructor() {}
constructor() {
// do nothing
}
}
2 changes: 1 addition & 1 deletion src/app/app.module.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { importProvidersFrom, NgModule } from '@angular/core';
import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';

import { AppRoutingModule } from './app-routing.module';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ <h3 class="z-20">{{data.description}}</h3>
<img [hidden]="loading" (load)="imageLoaded()" class="z-20"
src="{{data.img}}" alt>
</div>
@if (data.link && data.link != '') {
@if (data.link && data.link !== '') {
<app-button
variant="primary"
text="Revive la charla"
Expand Down Expand Up @@ -102,7 +102,7 @@ <h3 class="z-20">{{data.aditional[1].description}}</h3>
<h2
class="font-semibold text-lg md:text-xl mb-3 z-20">{{data.aditional[0].name}}</h2>
<h3 class="z-20">{{data.aditional[0].description}}</h3>
@if (data.link && data.link != '') {
@if (data.link && data.link !== '') {
<app-button
class="self-center mt-6"
variant="primary"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { Component, inject, TemplateRef } from '@angular/core';
import { MatIconModule } from '@angular/material/icon';
import { ButtonComponent } from '../button/button.component';
import { MatButtonModule } from '@angular/material/button';
import {
MAT_DIALOG_DATA,
MatDialog,
MatDialogModule,
MatDialogRef,
} from '@angular/material/dialog';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ export class FeaturesComponent implements OnInit {
@Input() features: Feature[] = [];
@Input() title = '';
@Input() subtitle = '';
constructor() {}
constructor() {
// do nothing
}

ngOnInit(): void {
// Initialization code here
// do nothing
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { NgFor } from '@angular/common';
import { Component, Input } from '@angular/core';
import { FooterLinkComponent } from '../footer-link/footer-link.component';
import { IconComponent } from '../../../../../shared/components/icons/icons.component';
import { Icon } from 'src/app/shared/interfaces/icons.interface';
import { Footer } from 'src/app/shared/interfaces/footer.interface';

@Component({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export class SFDHeaderComponent implements OnInit, AfterViewInit {
private initIntersectionObserver(): void {
const callback = (
entries: IntersectionObserverEntry[],
observer: IntersectionObserver
) => {
entries.forEach((entry) => {
if (entry.isIntersecting) {
Expand Down
1 change: 0 additions & 1 deletion src/app/pages/events/sfd-2024/sfd-2024.component.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Component } from '@angular/core';
import { SFD2024HeroComponent } from './components/hero/hero.component';
import { SFDHeaderComponent } from './components/header/header.component';
import { Header } from 'src/app/shared/interfaces/header.interface';
import { CountdownComponent } from 'src/app/shared/components/countdown/countdown.component';
import { agenda, features } from 'src/assets/content/sfd-features';
import { FeaturesComponent } from './components/features/features.component';
Expand Down
8 changes: 6 additions & 2 deletions src/app/pages/health/health.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ import { Component, OnInit } from '@angular/core';
styleUrls: ['./health.component.scss'],
})
export class HealthComponent implements OnInit {
constructor() {}
constructor() {
// do nothing
}

ngOnInit(): void {}
ngOnInit(): void {
// do nothing
}
}
4 changes: 3 additions & 1 deletion src/app/pages/main/main.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ export class MainComponent implements OnInit {
window.location.href = 'https://www.instagram.com/backboneutp/';
}

ngOnInit(): void {}
ngOnInit(): void {
// do nothing
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ import { Component, Input, OnInit } from '@angular/core';
export class IconsBlockComponent implements OnInit {
@Input() heading = '';
@Input() content = '';
constructor() {}
constructor() {
// do nothing
}

ngOnInit(): void {
// Initialization code goes here
// do nothing
}
}
4 changes: 3 additions & 1 deletion src/app/shared/components/icons/icons.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,7 @@ export class IconComponent {
@Input() iconName: Icon = 'system';
@Input() properties: { id: string; class: string } = { id: '', class: '' };

constructor() {}
constructor() {
// do nothing
}
}
6 changes: 4 additions & 2 deletions src/app/shared/components/logos-list/logos-list.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ export class LogosListComponent implements OnInit {
@Input() logos: Logo[] = [];
@Input() title = '';
@Input() subtitle = '';
constructor() {}
constructor() {
// do nothing
}

ngOnInit(): void {
// Initialization code goes here
// do nothing
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@
<li
*ngFor="let theme of themes"
class="themes-menu-option px-2 py-1.5 cursor-default hover:bg-neutral-400/40 dark:hover:bg-gray-500/50 dark:text-gray-200 rounded-sm"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think aria-disabled="true" conflicts with the current behavior because this element is still clickable and keyboard-actionable. For screen readers this can feel broken, so either remove aria-disabled or make the item truly disabled when that attribute is present.

role="button"
aria-disabled="true"
(click)="selectTheme(theme.toLowerCase())"
(keydown.enter)="selectTheme(theme.toLowerCase())"
>
{{ theme }}
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class ThemeToggleComponent {
}

@HostListener('document:click', ['$event'])
closeThemesMenu(event: Event): void {
closeThemesMenu(): void {
const themesMenu = document.getElementById('themes-menu');
themesMenu?.classList.remove('open');
}
Expand Down
5 changes: 3 additions & 2 deletions src/app/shared/components/timeline/timeline.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class="grid grid-cols-2 md:grid-cols-4 gap-10">
<div
class="relative pb-12 md:col-span-2 text-right space-x-4 justify-self-end md:w-64 mx-2">
<div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 == 0" (click)="openModal(item)">
<div class=" hover:scale-110 duration-700 transition-transform cursor-pointer sticky top-0" *ngIf="i % 2 === 0" (click)="openModal(item)" (keydown)="openModal(item)" role="button" aria-disabled="true">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keydown handler runs for any key press, so users navigating with keyboard arrows/tab could trigger the modal unintentionally. I’d suggest limiting this to Enter/Space (for example, (keydown.enter) and (keydown.space)) to keep behavior predictable.

<h3 class=" text-lg md:text-xl font-bold text-primary">
{{ item.name }}
</h3>
Expand All @@ -20,7 +20,8 @@ <h3 class=" text-lg md:text-xl font-bold text-primary">
<div
class=" relative md:mx-12 mx-2 pb-12 before:absolute before:left-[-35px] before:block before:h-full before:border-l-2 before:border-black/20 dark:before:border-white/15 before:content-['']">
<div class="relative pb-12 space-x-4 md:col-span-2 md:w-64 ">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a small template syntax issue here: there is no space between the (keydown) binding and role. That can make the template invalid or parsed incorrectly, so adding a space before role would make this safe.

<div class="sticky top-0" *ngIf="i % 2 != 0" (click)="openModal(item)">
<div class="sticky top-0" *ngIf="i % 2 !== 0" (click)="openModal(item)" (keydown)="openModal(item)"role="button"
aria-disabled="true">
<span
class="text-primary -left-[42px] absolute rounded-full text-5xl">&bull;</span>
<div class="hover:scale-110 duration-700 transition-transform cursor-pointer">
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/components/timeline/timeline.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { Component, inject, Input, OnInit } from '@angular/core';
import { TimelineEvent } from 'src/app/shared/interfaces/features.interface';
import {MatDialog} from '@angular/material/dialog';
import { CardPresentationComponent } from 'src/app/pages/events/sfd-2024/components/card-presentation/card-presentation.component';
import { ScrollStrategy, ScrollStrategyOptions } from '@angular/cdk/overlay';

@Component({
selector: 'app-timeline',
Expand All @@ -21,6 +20,7 @@ export class TimelineComponent implements OnInit {
readonly dialog = inject(MatDialog);

ngOnInit(): void {
// do nothing
}

openModal(item: any){
Expand Down