Expose b2_get_download_authorization response header overrides#576
Expose b2_get_download_authorization response header overrides#576Montana wants to merge 1 commit into
b2_get_download_authorization response header overrides#576Conversation
Add keyword-only parameters for the optional b2ContentDisposition, b2ContentLanguage, b2Expires, b2CacheControl, b2ContentEncoding, and b2ContentType fields accepted by b2_get_download_authorization. The fields are omitted from the request unless explicitly provided, preserving existing behavior. Fixes Backblaze#539.
|
Thanks for putting this together @Montana - exposing the response-header overrides on 1. The simulator wasn't updated. This change touches the abstract 2. No tests. We need coverage for the new behavior: that each field is forwarded when provided, that it's omitted from the request when left as 3. No changelog entry or documentation. Please add a changelog entry and document the new parameters where the method is described, so users can actually discover them. I think this should include the description of the behavior change, so that the users of the sdk don't have to go through the documentation of the API and through RFCs which define the expected client behavior. 4. Parameter naming. The One broader note: Happy to review again once these are in. |
Add keyword-only parameters for the optional
b2ContentDisposition,b2ContentLanguage,b2Expires,b2CacheControl,b2ContentEncoding, andb2ContentTypefields accepted byb2_get_download_authorization.The fields are omitted from the request unless explicitly provided, preserving existing behavior.
Fixes #539.