Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions diff_cover/diff_quality_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""

import argparse
import contextlib
import io
import logging
import os
Expand Down Expand Up @@ -321,12 +322,18 @@ def main(argv=None, directory=None):
reporter_factory_fn = hookimpl.function
break

if reporter or driver or reporter_factory_fn:
input_reports = []
# If none of the reporter, driver, or reporter_factory_fn are set
if not any((reporter, driver, reporter_factory_fn)):
LOGGER.error("Quality tool not recognized: '%s'", tool)
return 1

with contextlib.ExitStack() as stack:
try:
input_reports = []
for path in arg_dict["input_reports"]:
try:
input_reports.append(open(path, "rb"))
file_handle = stack.enter_context(open(path, "rb"))
input_reports.append(file_handle)
except OSError:
LOGGER.error("Could not load report '%s'", path)
return 1
Expand Down Expand Up @@ -371,14 +378,6 @@ def main(argv=None, directory=None):
except OSError as exc:
LOGGER.error("Failure: '%s'", str(exc))
return 1
# Close any reports we opened
finally:
for file_handle in input_reports:
file_handle.close()

else:
LOGGER.error("Quality tool not recognized: '%s'", tool)
return 1


if __name__ == "__main__":
Expand Down
Loading