Use Cooldown Coordinator to manage item movement cooldowns. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I created the previous PR, I have learned a lot about vanilla item movement and (after some discussion on the Fabric discord server) created a new mod called Cooldown Coordinator which is intended to allow mods like Ducts to coordinate their item movement cooldown timings.
Merging this PR would allow Ducts to coordinate item movement cooldowns correctly with vanilla Item Hoppers and also with any other mods which also use Cooldown Coordinator. It would also require Ducts to either package or depend on the Cooldown Coordinator library.
I would love to hear your feedback about Cooldown Coordinator in general; my hope in the long term is to get it or something similar merged into the Fabric API. If you are uninterested in resolving #4 please let me know that too; I will stop pestering you about it.
Note: This PR also fixes a minor error in use of the Fabric transfer API. The wrong (opposite) side of the target Storage is selected by the current Ducts implementation.