Skip to content

Low confidence threshold #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yannforget merged 3 commits into from
Jan 13, 2026
Merged

Low confidence threshold #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
869ecb5
feat: Add threshold parameter
yara-elkady Dec 23, 2025
34c154a
Fix: Adjust parameter to handle None
yara-elkady Dec 23, 2025
b3773fe
Adjust default value of threshold parameter to zero to avoid division…
yara-elkady Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions create-xlsform/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@
default="typing/data/xlsform",
required=True,
)
@parameter(
"low_confidence_threshold",
name="Low Confidence Threshold Percent",
help="Enter percentage. Segments with confidence percentage below this threshold will be marked as low-confidence",
type=float,
default=0.0,
required=False,
)
def create_xlsform(
config_spreadsheet: str,
cart_outputs: Dataset,
Expand All @@ -112,6 +120,7 @@ def create_xlsform(
enable_screening: bool,
typing_tool_version: str,
output_dir: str,
low_confidence_threshold: float,
) -> None:
"""Build XLSForm from CART outputs and configuration spreadsheet."""
data = load_dataset(dataset=cart_outputs, version_name=version_name)
Expand All @@ -123,7 +132,6 @@ def create_xlsform(
datetime.now().astimezone().strftime("%Y-%m-%d_%H-%M-%S"),
)
output_dir.mkdir(parents=True, exist_ok=True)

config = load_configuration(url=config_spreadsheet, output_dir=output_dir)
generate_form(
config=config,
Expand All @@ -134,6 +142,7 @@ def create_xlsform(
enable_screening=enable_screening,
output_dir=output_dir,
typing_tool_version=typing_tool_version,
low_confidence_threshold=low_confidence_threshold,
)


Expand Down Expand Up @@ -218,6 +227,7 @@ def generate_form(
exit_deadends_early: bool,
output_dir: Path,
typing_tool_version: str,
low_confidence_threshold: float = 0,
) -> None:
"""Build XLSForm from CART outputs and configuration spreadsheet."""
rural_cart = cart_data["rural"]
Expand Down Expand Up @@ -267,7 +277,10 @@ def generate_form(
current_run.log_info("Applied custom options")

root = add_segment_notes(
root, settings_config=config["settings"], segments_config=config["segments"]
root,
settings_config=config["settings"],
segments_config=config["segments"],
low_confidence_threshold=low_confidence_threshold,
)
current_run.log_info("Added segment notes")

Expand Down Expand Up @@ -339,8 +352,7 @@ def generate_form(

current_run.log_info(f"Successfully generated XLSForm at {dst_file}")
current_run.add_file_output(dst_file.as_posix())

mermaid = create_form_diagram(root, skip_notes=True)
mermaid = create_form_diagram(root, skip_notes=True, threshold=low_confidence_threshold)
fp = output_dir / f"{typing_tool_version}.txt"
with fp.open("w") as f:
f.write(mermaid)
Expand Down
Loading