ML Model Download Progress & Logo#434
Conversation
024d338 to
3e52bc6
Compare
385dda1 to
2f37129
Compare
Simpler version of BLAST-AI-ML#433: - Show download progress from MLFlow - Add the Genesis AMSC Logo and make it link to MLFlow model catalogue
2f37129 to
33f2286
Compare
|
Posting here some comments taken out of a Codex review:
They seem legit improvements to me and could be either separate commits in this PR or separate follow-up PRs. I already tested local patches for each of them, which do make the code a bit more minimal, but will wait to know what others think before going further. We can also discuss them in person if needed - whatever works best. |
|
I agree with 1-3, feel free to push commits on this PR @EZoni 4: I rather would cancel in-flight downloads. If I wanted an unhelpful, indetermine progress bar I could have avoided a lot of the lifting here. So either ignore or add a cancel. |
|
For 3 the pre-flight helper is not clear to me. I definitely want to have a is_model_available_on_mlflow() function, otherwise the async code and exception handling gets very messy and error prone. You want to minimize all exception handling in async functions, because they are notoriously brittle and hard to debug in python. So do 3. Carefully, it's overly eager in its recommendation. |
Simpler version of #433, subset ported over:
To do: