Making sure that empty branch inputs produce empty branch outputs#748
Draft
Making sure that empty branch inputs produce empty branch outputs#748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #701
This creates the behaviour requested in the issue.
That being said, I am not a big fan of this PR for a few reasons:
SolveInstance, once when actually executing the component, and once inAfterSolveInstance. The code also has a set of guardrails to make sure that behaviour is only occurring when for that specific scenario but it would be easy to miss another edge-case where it is now happening but is not desired. I am not fluent enough in complex GH workflow to tell.So, in summary, it feels that this PR is creating more problems than it is solving. It feels it would be preferable for everyone to have simple expected behaviour on BHoM components and, in exchange, ask users to keep their script clean. But I am not a GH expect so maybe I am missing something?
@michaelhoehn , I would appreciate your opinion on this one.
Test files
See issue
Changelog
Additional comments