Fixed multiple issues with parsing elements #2
Open
AizazZaidee wants to merge 3 commits intoBERef:masterfrom
Open
Fixed multiple issues with parsing elements #2AizazZaidee wants to merge 3 commits intoBERef:masterfrom
AizazZaidee wants to merge 3 commits intoBERef:masterfrom
Conversation
…hout {
% this is a comment
@misc{rydell1994bipolar,
month=feb # "~1",
title={Bipolar electrosurgical scalpel with paired loop electrodes},
author={Rydell, Mark A},
year={1994},
publisher={Google Patents},
note={US Patent 5,282,799}
}
Blueve
requested changes
Jun 19, 2019
Collaborator
Blueve
left a comment
Blueve
left a comment
There was a problem hiding this comment.
Could you please add UnitTest for your fix?
There should be two cases need to be added:
- comment line supporting
month=feb # "~1"
|
|
||
| if (c == '@') | ||
| { | ||
| { |
Collaborator
There was a problem hiding this comment.
There are redundant spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
BibTeXLibrary.Config.BeginCommentCharactersall the characters could be added that will be treated as comments and will be skipped. for example line starting with "%" in the following case.Elements like
month=feb # "~1"are valid and parseable.