Skip to content

[Koin Project][Refactor] 게시판 모듈 분리 #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kongwoojin wants to merge 7 commits into from
Closed

[Koin Project][Refactor] 게시판 모듈 분리 #1046

kongwoojin wants to merge 7 commits into from

Conversation

@kongwoojin
Copy link
Member

@kongwoojin kongwoojin commented Sep 24, 2025 •
edited
Loading

PR 개요

PR 체크리스트

  • Code convention을 잘 지켰나요?
  • Lint check를 수행하였나요?
  • Assignees를 추가했나요?

작업사항

  • 버그 수정
  • 신규 기능
  • 코드 스타일 수정 (포맷팅 등)
  • 리팩토링 (기능 수정 X, API 수정 X)
  • 기타

작업사항의 상세한 설명

  • feature/lostandfound를 feature/article로 수정했습니다.
  • 기존 게시판 코드를 feature/article 모듈로 분리했습니다.
  • article, lostandfound 두 디렉토리로 분리했습니다.
  • 중복된 model을 정리했습니다.
  • 코드 포맷팅이 잘못된 부분을 수정했습니다.

논의 사항

스크린샷

추가내용

  • develop, sprint 브랜치를 향하고 있습니다
  • production 브랜치를 향하고 있습니다

@kongwoojin kongwoojin self-assigned this Sep 24, 2025
@kongwoojin kongwoojin requested a review from a team as a code owner September 24, 2025 17:02
@github-actions github-actions bot added refactor Code refactoring koin project labels Sep 24, 2025
@kongwoojin kongwoojin linked an issue Sep 24, 2025 that may be closed by this pull request
[Koin Project] 게시판 리팩토링 #1043
Open
1 task
KYM-P
KYM-P approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@KYM-P KYM-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 코드 대이동

Base automatically changed from refactor/#1043-move-utils-to-core to develop September 25, 2025 10:35
@kongwoojin kongwoojin closed this Nov 7, 2025
@kongwoojin kongwoojin reopened this Jan 1, 2026
@kongwoojin kongwoojin marked this pull request as draft January 1, 2026 07:54
@kongwoojin kongwoojin marked this pull request as ready for review January 1, 2026 08:28
@kongwoojin kongwoojin requested a review from KYM-P January 1, 2026 08:28
@kongwoojin kongwoojin marked this pull request as draft January 1, 2026 10:08
@kongwoojin kongwoojin marked this pull request as ready for review January 1, 2026 10:18
@github-actions github-actions bot requested review from TTRR1007 and yunjaena January 1, 2026 10:18
@kongwoojin kongwoojin removed the request for review from yunjaena January 1, 2026 10:25
@yunjaena
Copy link
Contributor

yunjaena commented Jan 3, 2026

파일 변경이 너무 많네요 article 이동, 모델 변경 등 따로 pr이 들어가야될거 같아요

yunjaena
yunjaena reviewed Jan 3, 2026
View reviewed changes
domain/src/main/java/in/koreatech/koin/domain/util/DateFormatUtil.kt
return DateTimeFormatter.ofPattern("MM.dd").format(date)
}

fun getFullDate(date: LocalDate): String {
Copy link
Contributor

@yunjaena yunjaena Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSimple 로직이랑 유사한것 같은데 파라미터로 포맷 enum으로 받는거는 어떨까요?

Copy link
Member Author

@kongwoojin kongwoojin Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용하지 않는 함수라 일단 제거하겠습니다!

@kongwoojin
Copy link
Member Author

kongwoojin commented Jan 3, 2026

파일 변경이 너무 많네요 article 이동, 모델 변경 등 따로 pr이 들어가야될거 같아요

다시 작업해서 올리겠습니다!

@kongwoojin
Copy link
Member Author

kongwoojin commented Jan 3, 2026 •
edited
Loading

@kongwoojin kongwoojin closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunjaena yunjaena yunjaena left review comments

@JaeYoung290 JaeYoung290 Awaiting requested review from JaeYoung290

@KYM-P KYM-P Awaiting requested review from KYM-P

@TTRR1007 TTRR1007 Awaiting requested review from TTRR1007

Assignees

@kongwoojin kongwoojin

Labels

koin project refactor Code refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Koin Project] 게시판 리팩토링

4 participants

@kongwoojin @yunjaena @KYM-P