-
Notifications
You must be signed in to change notification settings - Fork 12
[김은서_Android] 11주차 과제 제출 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kongwoojin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
코멘트 확인해주세요
| startButton.text = getString(R.string.main_start) | ||
| } | ||
|
|
||
| private fun formatTime(ms: Long): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long의 확장함수로 작성하면 더 좋을 것 같습니다
| } | ||
|
|
||
| lapButton.setOnClickListener { | ||
| if (!isRunning) return@setOnClickListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return 처리 좋습니다
| lapButton.setOnClickListener { | ||
| if (!isRunning) return@setOnClickListener | ||
|
|
||
| val now = SystemClock.elapsedRealtime() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오오... SystemClock.elapsedRealtime()를 사용하셨군요 좋습니다!
System.currentTimeMillis()와의 차이점도 알아보시면 좋을 것 같네요
| @@ -0,0 +1,5 @@ | |||
| data class LapData( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소한 점이긴 한데, package name이 누락되어 있네요
No description provided.