Skip to content

Conversation

@domily-jo
Copy link

No description provided.

Copy link
Contributor

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
코멘트 확인해주세요

startButton.text = getString(R.string.main_start)
}

private fun formatTime(ms: Long): String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long의 확장함수로 작성하면 더 좋을 것 같습니다

}

lapButton.setOnClickListener {
if (!isRunning) return@setOnClickListener
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return 처리 좋습니다

lapButton.setOnClickListener {
if (!isRunning) return@setOnClickListener

val now = SystemClock.elapsedRealtime()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오... SystemClock.elapsedRealtime()를 사용하셨군요 좋습니다!
System.currentTimeMillis()와의 차이점도 알아보시면 좋을 것 같네요

@@ -0,0 +1,5 @@
data class LapData(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 점이긴 한데, package name이 누락되어 있네요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants