Skip to content

Harden MediaConvert video webhook#81

Open
nexicturbo wants to merge 1 commit into
BAWES-Universe:masterfrom
nexicturbo:codex/mediaconvert-webhook-hardening-55
Open

Harden MediaConvert video webhook#81
nexicturbo wants to merge 1 commit into
BAWES-Universe:masterfrom
nexicturbo:codex/mediaconvert-webhook-hardening-55

Conversation

@nexicturbo
Copy link
Copy Markdown

Summary

  • validate public MediaConvert webhook events before mutating candidate video state
  • require event resources to match the job id and UserMetadata.User to match the candidate found for that job
  • normalize MediaConvert status handling so only COMPLETE stores output files, ERROR clears failed videos, and incomplete events do not mark videos processed
  • add a focused regression check for the hardening guards

/claim #55

Validation

  • python3 tests/check-mediaconvert-webhook-hardening.py
  • git diff --check

Note: PHP/Codeception could not be run in this local environment because php is not installed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Warning

Rate limit exceeded

@nexicturbo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 60 minutes before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1c95474f-53cb-4ed7-b47c-2ae4838c2506

📥 Commits

Reviewing files that changed from the base of the PR and between 7b023ff and 4143345.

📒 Files selected for processing (2)
  • candidate/modules/v1/controllers/AccountController.php
  • tests/check-mediaconvert-webhook-hardening.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nexicturbo
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nexicturbo
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nexicturbo
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant