Add Code coverage comparison for Msal, it is not blocking, Fixes AB#3506772#2442
Merged
Add Code coverage comparison for Msal, it is not blocking, Fixes AB#3506772#2442
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request activates code coverage functionality in the unit test pipeline by uncommenting previously disabled pipeline stages and removing unit tests from AuthenticationResultTest.
Changes:
- Uncomments the
build_test_devjob that runs tests against the dev branch and publishes JaCoCo coverage reports - Uncomments the
compare_coveragestage that compares coverage between PR and dev branches - Removes four unit tests for correlation ID handling from AuthenticationResultTest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| azure-pipelines/pull-request-validation/pr-msal.yml | Activates code coverage pipeline by uncommenting build_test_dev job and compare_coverage stage |
| msal/src/test/java/com/microsoft/identity/client/AuthenticationResultTest.java | Removes all four correlation ID unit tests, leaving only the setup method |
|
✅ Work item link check complete. Description contains link AB#3421522 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3421522 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
cacosta33
approved these changes
Feb 9, 2026
rpdome
approved these changes
Feb 10, 2026
rpdome
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting up code coverage checks in PRs. the check does the comparison between pr branch and dev, but it is not blocking at this time.
Common PR: AzureAD/microsoft-authentication-library-common-for-android#2884
AB#3506772