Skip to content

Add Code coverage comparison for Msal, it is not blocking, Fixes AB#3506772#2442

Merged
fadidurah merged 23 commits intodevfrom
fadi/cod-cov-2
Feb 12, 2026
Merged

Add Code coverage comparison for Msal, it is not blocking, Fixes AB#3506772#2442
fadidurah merged 23 commits intodevfrom
fadi/cod-cov-2

Conversation

@fadidurah
Copy link
Copy Markdown
Collaborator

@fadidurah fadidurah commented Feb 3, 2026

Setting up code coverage checks in PRs. the check does the comparison between pr branch and dev, but it is not blocking at this time.

Common PR: AzureAD/microsoft-authentication-library-common-for-android#2884

AB#3506772

@fadidurah fadidurah marked this pull request as ready for review February 3, 2026 17:53
@fadidurah fadidurah requested a review from a team as a code owner February 3, 2026 17:53
Copilot AI review requested due to automatic review settings February 3, 2026 17:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request activates code coverage functionality in the unit test pipeline by uncommenting previously disabled pipeline stages and removing unit tests from AuthenticationResultTest.

Changes:

  • Uncomments the build_test_dev job that runs tests against the dev branch and publishes JaCoCo coverage reports
  • Uncomments the compare_coverage stage that compares coverage between PR and dev branches
  • Removes four unit tests for correlation ID handling from AuthenticationResultTest

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
azure-pipelines/pull-request-validation/pr-msal.yml Activates code coverage pipeline by uncommenting build_test_dev job and compare_coverage stage
msal/src/test/java/com/microsoft/identity/client/AuthenticationResultTest.java Removes all four correlation ID unit tests, leaving only the setup method

Comment thread azure-pipelines/pull-request-validation/pr-msal.yml Outdated
Comment thread azure-pipelines/pull-request-validation/pr-msal.yml Outdated
@fadidurah fadidurah requested a review from a team as a code owner February 3, 2026 19:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

✅ Work item link check complete. Description contains link AB#3421522 to an Azure Boards work item.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

❌ Work item link check failed. Description contains AB#3421522 but the Bot could not link it to an Azure Boards work item.

Click here to learn more.

@github-actions github-actions Bot changed the title Activate Code Coverage in unit test pipeline Activate Code Coverage in unit test pipeline, Fixes AB#3421522 Feb 4, 2026
@fadidurah fadidurah changed the title Activate Code Coverage in unit test pipeline, Fixes AB#3421522 Add Code coverage comparison for Msal, it is not blocking Feb 9, 2026
@github-actions github-actions Bot changed the title Add Code coverage comparison for Msal, it is not blocking Add Code coverage comparison for Msal, it is not blocking, Fixes AB#3506772 Feb 10, 2026
@fadidurah fadidurah merged commit d82e5ab into dev Feb 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants