Revert @identifiers decorator and deprecate x-ms-identifiers generation#3779
Revert @identifiers decorator and deprecate x-ms-identifiers generation#3779
Conversation
- Remove @Identifiers decorator from typespec-azure-resource-manager - Remove automatic x-ms-identifiers generation from @key decorator - Remove x-ms-identifiers generation logic from typespec-autorest - Revert to using @OpenAPI.extension("x-ms-identifiers", ...) - Remove related tests for @Identifiers decorator - Update documentation to reflect the changes - Add deprecation changelog entry This reverts changes introduced in PR #1983
|
All changed packages have been documented.
Show changes
|
- Remove identifiers.test.ts that references deleted functions - Replace @Identifiers with @OpenAPI.extension in library files - Disable missing-x-ms-identifiers rule (mark as deprecated) - Update rule message to indicate deprecation
…schema, regenerate samples
commit: |
|
You can try these changes here
|
There was a problem hiding this comment.
@qiaozha before this happens we need full confirmation from ARM team that this is uncesssary and this change cannot be done in such a breaking manner. It needs to be rolled out following the process we've established.
- deprecate only
- migrate everything in spec repo
- remove 1-2 sprint later
|
Hi @@qiaozha. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
Summary
This PR reverts the changes introduced in PR #1983 which added the @Identifiers decorator and automatic x-ms-identifiers generation from @key decorator.
Changes
Related Issues
Reverts: #1983
Breaking Changes