Use the helm release namespace by default instead of creating a new one #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 72.05% 72.57% +0.52%
==========================================
Files 37 26 -11
Lines 2340 1462 -878
==========================================
- Hits 1686 1061 -625
+ Misses 654 401 -253 🚀 New features to boost your workflow:
|
avtakkar
reviewed
May 16, 2025
Contributor
avtakkar
left a comment
avtakkar
left a comment
There was a problem hiding this comment.
Thanks for your PR. Just left a few comments wondering if it can be done another way to retain the namespace variable.
| {{- end }} | ||
|
|
||
| {{- define "peerd.namespace" -}} | ||
| {{- if .Values.peerd.namespace.k8s }} |
Contributor
There was a problem hiding this comment.
Can we set this to {{ .Release.Namespace }} instead?
Contributor
There was a problem hiding this comment.
I tried a CI run on Azure and peerd-ns is not cleaned up anymore after the run.
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: {{ include "peerd.namespace" . }} |
Contributor
There was a problem hiding this comment.
This template can then be retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peerd helm charts now use helm release namespace instead of creating a new namespace on its own.
Resolves #68