Add ShutdownHandle to Otel to gracefully shutdown component while it is running #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Otel::new() to return (Otel, mpsc::Sender<()>) - Remove redundant shutdown methods, use channel directly - Centralize graceful shutdown logic in run() method - Update sample app and tests to use tuple return pattern - Add target/ directories to .gitignore
patilsnr
changed the title
danewalton-msft
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current sample app that uses
shutdown()onOtelcomponents to gracefully shutdown and flush logs does not compile. This change adds a wrapper function around theOtelconstructor to return a shutdown handler, which allows more explicit control and ownership of the shutdown handler.Changes
Tests
Sample app run and works, integration tests pass.