Open
Conversation
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
src/misc/msccl/msccl_lifecycle.cc
Outdated
| NCCLCHECK(mscclRunSavedParams()); | ||
| break; | ||
| } | ||
| if (comm->mscclCompatible) { |
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
| inline __device__ bool checkAbort(int &spins) { | ||
| spins++; | ||
| if (!(flags & Aborted) && spins == NCCL_SPINS_BEFORE_CHECK_ABORT) { | ||
| printf("checkAbort Simple, abortFlag:%u \n", *ncclShmem.comm.abortFlag); |
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
yzygitzh
reviewed
Dec 12, 2023
Contributor
yzygitzh
left a comment
yzygitzh
left a comment
There was a problem hiding this comment.
- Need force synchronize after each COLL call. Maybe after each ncclEnqueueCheck and mscclEnqueueCheck, like cudaStreamSynchronize().
- Need a global flag switch on/off resilience feature, including disabling proxy thread, disabling stream synchronization, and logics in msccl_lifecycle.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.