Copy from Opc2Wot dev branch improvements for codegen from multiple TMs#1222
Merged
Copy from Opc2Wot dev branch improvements for codegen from multiple TMs#1222
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for generating code from multiple WoT Thing Models by introducing a --prefixSchemas CLI option to avoid naming collisions across Thing Models. It also extends support for underscores in 'title' values from Thing Models to JSON Schema definitions, and improves validation logic to only warn about missing affordances when no affordances exist across the entire Thing Model collection.
Changes:
- Added
--prefixSchemasCLI option to apply Thing Model prefixes to schema type names - Extended regex pattern to allow underscores in JSON Schema 'title' values (matching existing WoT Thing Model support)
- Refactored validation to check for affordances across entire Thing Model collections rather than individual models
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| JsonSchemaStandardizer.cs | Updated TitleRegex and error message to allow underscores in JSON Schema title values |
| OptionContainer.cs | Added PrefixSchemas property for the new CLI option |
| Program.cs | Added --prefixSchemas command-line option definition and wiring |
| CommandPerformer.cs | Threading prefixSchemas parameter through ParseThings and TryGetSchemaNamer, plus calling ValidateThingCollection |
| ThingValidator.cs | Added ValidateThingCollection method to aggregate affordances across multiple Thing Models before warning |
| SchemaNamer.cs | Added prefix support throughout all schema naming methods with new Prefix helper |
timtay-microsoft
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several improvements that support codegen from multiple Thing Models, needed for converted OPC UA companion specs:
--prefixSchemasCLI option to avoid collisions when generating from multiple TMs