Configure CONNECT timeout on Netty proxying #47554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
a team,
JonathanGiles,
anuchandy,
samvaity,
srnagar and
vcolin7
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances proxy connection handling by applying the configured CONNECT timeout to proxy connection attempts in the Netty HTTP client. Previously, the connect timeout was only applied to the main HTTP client connection but not to the proxy CONNECT operation itself.
Key Changes:
- Extracted
connectTimeoutMilliscalculation to a reusable variable to avoid code duplication - Applied the connect timeout to authenticated proxy handlers (custom
HttpProxyHandler) - Applied the connect timeout to non-authenticated proxies via Reactor Netty's
connectTimeoutMillis()method
...ure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...ure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
samvaity
approved these changes
Dec 18, 2025
| nettyHttpClient | ||
| = nettyHttpClient.proxy(proxy -> proxy.type(toReactorNettyProxyType(buildProxyOptions.getType())) | ||
| .socketAddress(buildProxyOptions.getAddress()) | ||
| .connectTimeoutMillis(connectTimeoutMillis) |
Member
There was a problem hiding this comment.
are there any testing changes needed to validate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When proxying adds the configured CONNECT timeout to the proxy connection attempt.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines