Skip to content

[SecurityInsights] Redact credentials from test recording headers to fix CredScan#29336

Merged
JiaSeng-v merged 3 commits intoAzure:joyer/SecurityInsights-migrate-v4from
hadasi6:hadas/securityinsights-v4-recordings
Mar 30, 2026
Merged

[SecurityInsights] Redact credentials from test recording headers to fix CredScan#29336
JiaSeng-v merged 3 commits intoAzure:joyer/SecurityInsights-migrate-v4from
hadasi6:hadas/securityinsights-v4-recordings

Conversation

@hadasi6
Copy link
Copy Markdown

@hadasi6 hadasi6 commented Mar 29, 2026

Description

Redacted tenantId and objectId from x-ms-operation-identifier response headers in all recording
files to pass CI credential scan.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

hadasi6 added 3 commits March 25, 2026 23:45
…m/Azure/azure-powershell into hadas/securityinsights-v4-recordings

# Conflicts:
#	src/SecurityInsights/SecurityInsights.Autorest/docs/Az.SecurityInsights.md
#	src/SecurityInsights/SecurityInsights.Autorest/generate-info.json
#	src/SecurityInsights/SecurityInsights.Autorest/test/New-AzSentinelAlertRuleAction.Recording.json
#	src/SecurityInsights/SecurityInsights.Autorest/test/Update-AzSentinelAlertRuleAction.Recording.json
#	src/SecurityInsights/SecurityInsights.Autorest/test/deployment-templates/alertRuleAction/template.parameters.json
#	src/SecurityInsights/SecurityInsights.Autorest/test/env.json
#	src/SecurityInsights/SecurityInsights.sln
#	src/SecurityInsights/SecurityInsights/Az.SecurityInsights.psd1
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Thank you for your contribution @hadasi6! We will review the pull request and get back to you soon.

@hadasi6
Copy link
Copy Markdown
Author

hadasi6 commented Mar 29, 2026

@microsoft-github-policy-service agree company="Microsoft"

@JiaSeng-v JiaSeng-v merged commit 2e4a62a into Azure:joyer/SecurityInsights-migrate-v4 Mar 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants