[Storage] Support encryption in transit #29083

yifanz7 · 2026-01-20T06:55:35Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-01-20T06:55:38Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

This pull request adds support for encryption in transit configuration for both SMB and NFS protocols in Azure Storage file service properties.

Changes:

Added new PowerShell parameters SmbEncryptionInTransitRequired and NfsEncryptionInTransitRequired to Update-AzStorageFileServiceProperty cmdlet
Extended model classes to support NFS settings and encryption in transit properties
Updated display format to show the new encryption in transit properties
Added comprehensive test coverage for both SMB and NFS encryption in transit scenarios

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
Storage.Management.format.ps1xml	Added display entries for SMB and NFS encryption in transit properties in the file service properties list view
PSFileServiceProperties.cs	Extended model classes with PSNfsSetting and PSEncryptionInTransit to represent the new encryption in transit settings
UpdateAzAzStorageFileServiceProperty.cs	Added two new boolean parameters for SMB and NFS encryption in transit, with implementation logic to set these properties on file service
ChangeLog.md	Documented the new encryption in transit support feature in the upcoming release section
StorageFileTests.ps1	Added test scenarios validating both SMB and NFS encryption in transit can be enabled and disabled

Copilot · 2026-01-20T07:05:36Z

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs


+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Enable Multichannel by set to $true, disable Multichannel by set to $false. Applies to Premium FileStorage only.")]


The help message incorrectly describes this parameter as "Enable Multichannel" when it should describe SMB encryption in transit functionality. Update the help message to accurately describe this parameter's purpose, such as "Enable or disable encryption in transit for SMB protocol. Set to $true to require encryption, $false to disable."

Suggested change

HelpMessage = "Enable Multichannel by set to $true, disable Multichannel by set to $false. Applies to Premium FileStorage only.")]

HelpMessage = "Enable or disable encryption in transit for SMB protocol. Set to $true to require encryption, $false to disable. Applies to Premium FileStorage only.")]

Copilot · 2026-01-20T07:05:37Z

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs

+
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Enable Multichannel by set to $true, disable Multichannel by set to $false. Applies to Premium FileStorage only.")]


The help message incorrectly describes this parameter as "Enable Multichannel" when it should describe NFS encryption in transit functionality. Update the help message to accurately describe this parameter's purpose, such as "Enable or disable encryption in transit for NFS protocol. Set to $true to require encryption, $false to disable."

Suggested change

HelpMessage = "Enable Multichannel by set to $true, disable Multichannel by set to $false. Applies to Premium FileStorage only.")]

HelpMessage = "Enable or disable encryption in transit for NFS protocol. Set to $true to require encryption, $false to disable.")]

Copilot · 2026-01-20T07:05:37Z

src/Storage/Storage.Management/Storage.Management.format.ps1xml

+              <ListItem>
+                  <Label>ProtocolSettings.Nfs.EncryptionInTransit.Required</Label>
+                  <ScriptBlock>$_.ProtocolSettings.Nfs.EncryptionInTransit.Required</ScriptBlock>
+              </ListItem> 


There is trailing whitespace at the end of this line. Remove the trailing whitespace to maintain code consistency.

Suggested change

</ListItem>

</ListItem>

Copilot · 2026-01-20T07:05:37Z

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs

+                        if (protocolSettings.Smb.EncryptionInTransit == null)
+                        {
+                            protocolSettings.Smb.EncryptionInTransit = new EncryptionInTransit(this.smbEncryptionInTransitRequired);
+                        }


The null check for protocolSettings.Smb.EncryptionInTransit is unnecessary since a new SmbSetting instance is always created at line 266, which would have this property as null by default. For consistency with the similar Multichannel property handling (lines 283-287), remove the inner null check and directly instantiate the EncryptionInTransit object.

Suggested change

if (protocolSettings.Smb.EncryptionInTransit == null)

{

protocolSettings.Smb.EncryptionInTransit = new EncryptionInTransit(this.smbEncryptionInTransitRequired);

}

protocolSettings.Smb.EncryptionInTransit = new EncryptionInTransit(this.smbEncryptionInTransitRequired);

Copilot · 2026-01-20T07:05:37Z

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs

                    this.SmbKerberosTicketEncryption != null ||
                    this.SmbChannelEncryption != null ||
-                    this.enableSmbMultichannel != null)
+                    this.enableSmbMultichannel != null || 


There is trailing whitespace at the end of this line. Remove the trailing whitespace to maintain code consistency.

Copilot · 2026-01-20T07:05:38Z

src/Storage/Storage.Management/Models/PSFileServiceProperties.cs

+        }
+    }
+
+    public class PSEncryptionInTransit { 


There is trailing whitespace at the end of this line after the opening brace. Remove the trailing whitespace to maintain code consistency.

Suggested change

public class PSEncryptionInTransit {

public class PSEncryptionInTransit {

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

vidai-msft

Please update the help doc since new params have been introduced.

yifanz7 added 3 commits January 13, 2026 11:37

Add support for encryption in transit in file service properties

01d3bd2

remove unused imports

10e4211

add tests and changelog

335924c

Copilot AI review requested due to automatic review settings January 20, 2026 06:55

Copilot started reviewing on behalf of yifanz7 January 20, 2026 06:58 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

blueww reviewed Jan 20, 2026

View reviewed changes

src/Storage/Storage.Management/File/UpdateAzAzStorageFileServiceProperty.cs Outdated Show resolved Hide resolved

yifanz7 added 2 commits January 20, 2026 15:21

remove unnecessary check

97ef45a

resolve merge conflicts

391e51f

Copilot AI review requested due to automatic review settings January 20, 2026 07:28

Copilot started reviewing on behalf of yifanz7 January 20, 2026 07:31 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

vidai-msft requested changes Jan 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Storage] Support encryption in transit #29083

[Storage] Support encryption in transit #29083

yifanz7 commented Jan 20, 2026

Uh oh!

azure-client-tools-bot-prd bot commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

vidai-msft left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	HelpMessage = "Enable Multichannel by set to $true, disable Multichannel by set to $false. Applies to Premium FileStorage only.")]
	HelpMessage = "Enable or disable encryption in transit for SMB protocol. Set to $true to require encryption, $false to disable. Applies to Premium FileStorage only.")]

	public class PSEncryptionInTransit {
	public class PSEncryptionInTransit {

[Storage] Support encryption in transit #29083

Are you sure you want to change the base?

[Storage] Support encryption in transit #29083

Conversation

yifanz7 commented Jan 20, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vidai-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants