Skip to content

Conversation

@JiaSeng-v
Copy link

@JiaSeng-v JiaSeng-v commented Jan 20, 2026

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings January 20, 2026 03:31
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request announces breaking changes for the SignalR PowerShell module, specifically targeting the removal of several debugging and proxy-related parameters from WebPubSub cmdlets in the upcoming Az v16.0.0 release (May 2026).

Changes:

  • Removed deprecated parameter documentation from 26 help markdown files (-Break, -HttpPipelineAppend, -HttpPipelinePrepend, -Proxy, -ProxyCredential, -ProxyUseDefaultCredentials)
  • Added breaking change pre-announcement to ChangeLog.md
  • Updated module manifest files with new generation dates, cmdlet export list alphabetization, and dependency updates
  • Added breaking change preview messages to cmdlets via AutoRest directives
  • Reorganized solution file with new project GUIDs and build configurations

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/SignalR/SignalR/ChangeLog.md Added pre-announcement of breaking changes with reference link
src/SignalR/SignalR/help/*.md (26 files) Removed documentation for deprecated parameters (Break, HttpPipelineAppend, HttpPipelinePrepend, Proxy, ProxyCredential, ProxyUseDefaultCredentials); Added blank lines for formatting; Updated type names to fully-qualified names
src/SignalR/SignalR/Az.SignalR.psd1 Updated generation date, alphabetized cmdlet exports, uncommented ScriptsToProcess and TypesToProcess, changed path separators to forward slashes for cross-platform compatibility
src/SignalR/SignalR.Autorest/custom/scripts/New-AzWebPubSub.ps1 Added PreviewMessage attribute with breaking change warning
src/SignalR/SignalR.Autorest/README.md Added AutoRest directive to apply preview-announcement to New and Update WebPubSub cmdlets
src/SignalR/SignalR.Autorest/Az.SignalR.nuspec Updated Az.Accounts dependency from previous version to 2.7.5
src/SignalR/SignalR.Autorest/Properties/AssemblyInfo.cs New file with assembly metadata (version 2.3.2)
src/SignalR/SignalR.Autorest/resources/README.md New file documenting the resources directory purpose
src/SignalR/SignalR.Autorest/generate-info.json Updated generation ID
src/SignalR/SignalR.Autorest/docs/Az.SignalR.md Updated module GUID
src/SignalR/SignalR.sln Updated project references and build configurations with new GUIDs and platform targets

Comment on lines 97 to 100
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview message in the PreviewMessage attribute contains inconsistent formatting. Line 97 starts with excessive asterisks (88 characters) while line 101 has only 99 asterisks. The message should use consistent border formatting for better readability. Additionally, line 99 has inconsistent spacing with many extra spaces after "cmdlet."

Suggested change
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("***************************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n

Copilot uses AI. Check for mistakes.
<tags>Azure ResourceManager ARM PSModule $(service-name)</tags>
<dependencies>
<dependency id="Az.Accounts" version="2.2.3" />
<dependency id="Az.Accounts" version="2.7.5" />
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Az.Accounts dependency version is inconsistent between files. The nuspec file specifies version 2.7.5, but the module manifest (Az.SignalR.psd1) requires version 5.3.2. These versions should be synchronized to ensure consistent dependencies.

Suggested change
<dependency id="Az.Accounts" version="2.7.5" />
<dependency id="Az.Accounts" version="5.3.2" />

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 20, 2026 06:19
[CmdletBinding(DefaultParameterSetName='CreateExpanded', PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe the breaking change more detail? What will be the breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-IdentityType SystemAssigned will be changed to -EnableSystemAssignedIdentity

subject: WebPubSub
set:
preview-announcement:
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe the breaking change more detail? What will be the breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-IdentityType SystemAssigned will be changed to -EnableSystemAssignedIdentity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yunchi @wyunchi-ms,

This breaking change announcement is for the Autorest v4 upgrade, which introduces a large number of repeated breaking changes across different cmdlets.

After discussing with Xiaogang and Yeming, we agreed to create a centralized breaking change list for users to review as mentioned in the BC message. The consolidated list can be found here: https://go.microsoft.com/fwlink/?linkid=2333486

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Comment on lines 97 to 101
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview message contains inconsistent formatting with extra leading whitespace on some lines. The indentation should be consistent, or the message should be formatted as a single line. This will display incorrectly to users when the cmdlet is executed.

Suggested change
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
***************************************************************************************************")]
[Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Runtime.PreviewMessage("This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. At least one change applies to this cmdlet. See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486.")]

Copilot uses AI. Check for mistakes.
subject: WebPubSub
set:
preview-announcement:
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview-message in the directive uses different formatting than the custom script. The README.md directive uses escaped newlines (\r\n) and different asterisk counts, which may produce inconsistent messages to users between the same cmdlets. The messages should be identical for consistency.

Suggested change
preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *\\r\\n* At least one change applies to this cmdlet. *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *\\r\\n**************************************************************************************************"
preview-message: |
**************************************************************************************************
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *
* At least one change applies to this cmdlet. *
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *
**************************************************************************************************

Copilot uses AI. Check for mistakes.
@Pan-Qi Pan-Qi added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants