[Storage] Add support for delegation sas public preview- B/Q/F/DFS #29031

blueww · 2026-01-07T07:06:22Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-01-07T07:06:26Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

github-actions · 2026-01-07T07:06:38Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

src/Storage/Storage/File/Cmdlet/NewAzureStorageFileSasToken.cs

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 16 comments.

src/Storage/Storage/File/Cmdlet/NewAzureStorageShareSasToken.cs

src/Storage/Storage/Blob/Cmdlet/NewAzureStorageContainerSasToken.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/NewAzDataLakeGen2SasToken.cs

src/Storage/Storage/Common/Cmdlet/NewAzureStorageContext.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/GetAzDataLakeGen2FileContent.cs

src/Storage/Storage/Blob/Cmdlet/SetAzureStorageBlobContent.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/GetAzDataLakeGen2FileContent.cs

src/Storage/Storage/File/Cmdlet/NewAzureStorageFileSasToken.cs

src/Storage/Storage/File/Cmdlet/NewAzureStorageShareSasToken.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/GetAzDataLakeGen2FileContent.cs

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 8 comments.

src/Storage/Storage/DatalakeGen2/Cmdlet/GetAzDataLakeGen2FileContent.cs

src/Storage/Storage/Blob/Cmdlet/CopyAzureStorageBlob.cs

src/Storage/Storage/Storage.csproj

src/Storage/Storage/File/Cmdlet/NewAzureStorageFileSasToken.cs

src/Storage/Storage/Queue/Cmdlet/NewAzureStorageQueueSasToken.cs

src/Storage/Storage/File/Cmdlet/NewAzureStorageShareSasToken.cs

src/Storage/Storage/Common/Cmdlet/NewAzureStorageContext.cs

Copilot

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 12 comments.

src/Storage/Storage/Common/SasTokenHelper.cs

src/Storage/Storage/Blob/Cmdlet/SetAzureStorageBlobContent.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/GetAzDataLakeGen2FileContent.cs

src/Storage/Storage/Queue/Cmdlet/NewAzureStorageQueueSasToken.cs

src/Storage/Storage/DatalakeGen2/Cmdlet/NewAzDataLakeGen2SasToken.cs

src/Storage/Storage/Blob/Cmdlet/NewAzureStorageContainerSasToken.cs

src/Storage/Storage/Blob/Cmdlet/NewAzureStorageBlobSasToken.cs

src/Storage/Storage/Common/SasTokenHelper.cs

src/Storage/Storage/Common/Cmdlet/NewAzureStorageContext.cs

blueww · 2026-01-19T06:52:20Z

@vidai-msft

The PR static analysis failed since following breaking issue.
However, the related cmdlet code and help file not change in this PR, and they have no changed for a long time.
Any idea?

``
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Table.Cmdlet.GetAzureStorageTableStoredAccessPolicyCommand","Get-AzStorageTableStoredAccessPolicy","0","1020","The cmdlet 'Get-AzStorageTableStoredAccessPolicy' no longer has output type 'Microsoft.Azure.Cosmos.Table.SharedAccessTablePolicy'.","Make cmdlet 'Get-AzStorageTableStoredAccessPolicy' return type 'Microsoft.Azure.Cosmos.Table.SharedAccessTablePolicy'."

vidai-msft · 2026-01-20T10:38:44Z

/azp run

azure-pipelines · 2026-01-20T10:38:52Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

vidai-msft · 2026-01-20T10:40:35Z

@vidai-msft

The PR static analysis failed since following breaking issue. However, the related cmdlet code and help file not change in this PR, and they have no changed for a long time. Any idea?

`` "Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Table.Cmdlet.GetAzureStorageTableStoredAccessPolicyCommand","Get-AzStorageTableStoredAccessPolicy","0","1020","The cmdlet 'Get-AzStorageTableStoredAccessPolicy' no longer has output type 'Microsoft.Azure.Cosmos.Table.SharedAccessTablePolicy'.","Make cmdlet 'Get-AzStorageTableStoredAccessPolicy' return type 'Microsoft.Azure.Cosmos.Table.SharedAccessTablePolicy'."

This breaking change issue has been suppressed. Looks like false positive.

vidai-msft · 2026-01-20T10:43:30Z

@blueww Please help resolve the conflicts.

vidai-msft

LGTM

Copilot AI review requested due to automatic review settings January 7, 2026 07:06

blueww added the Do Not Merge 🚫 label Jan 7, 2026

blueww marked this pull request as draft January 7, 2026 07:06

Copilot started reviewing on behalf of blueww January 7, 2026 07:08 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

EmmaZhu reviewed Jan 12, 2026

View reviewed changes

src/Storage/Storage/File/Cmdlet/NewAzureStorageFileSasToken.cs Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 13, 2026 06:48

blueww force-pushed the DSAS_skduoid2 branch from 5f0da6d to 04d7e27 Compare January 13, 2026 06:48

Copilot started reviewing on behalf of blueww January 13, 2026 06:51 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 07:34

blueww force-pushed the DSAS_skduoid2 branch from 787d08f to bdd18d0 Compare January 13, 2026 07:34

Copilot started reviewing on behalf of blueww January 13, 2026 07:37 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 08:45

blueww force-pushed the DSAS_skduoid2 branch from 9223916 to 246f648 Compare January 15, 2026 08:45

blueww changed the base branch from main to Az.Storage-preview January 15, 2026 08:45

Copilot started reviewing on behalf of blueww January 15, 2026 08:48 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

blueww marked this pull request as ready for review January 15, 2026 09:55

blueww changed the title ~~[DO NOT MERGE] [Storage] Add support for delegation sas - fix comments~~ [Storage] Add support for delegation sas public preview- B/Q/F/DFS Jan 15, 2026

blueww added needs-review and removed Do Not Merge 🚫 labels Jan 19, 2026

vidai-msft closed this Jan 20, 2026

vidai-msft reopened this Jan 20, 2026

EmmaZhu and others added 11 commits January 21, 2026 09:32

Add support for delegation sas

80dd42b

Fix comments

1f9b0ef

Block create SAS with Oauth+SAS credential

7e540d6

Fix SRP test failure since SDK version mismatch

80b443e

Fix after test F,Q,DFS

5f5d765

fix comments

ad14771

fix after blob test

4968821

Fix issues

c84ca12

Add help and change log

5021bd4

Fix comments

ab71217

Fix after regression test

4cef047

blueww force-pushed the DSAS_skduoid2 branch from 8affc29 to 4cef047 Compare January 21, 2026 01:43

vidai-msft approved these changes Jan 21, 2026

View reviewed changes

vidai-msft merged commit 5ef348a into Azure:Az.Storage-preview Jan 21, 2026
12 checks passed

[Storage] Add support for delegation sas public preview- B/Q/F/DFS #29031

[Storage] Add support for delegation sas public preview- B/Q/F/DFS #29031

Conversation

blueww commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueww commented Jan 19, 2026

Uh oh!

vidai-msft commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

vidai-msft commented Jan 20, 2026

Uh oh!

vidai-msft commented Jan 20, 2026

Uh oh!

vidai-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blueww commented Jan 7, 2026 •

edited

Loading