{Compute} migrate vm disk attach/detach to aaz #32675
Open
+14,226
−27,173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiii99
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @huiii99, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates az vm disk attach / az vm disk detach from handwritten SDK logic to AAZ-based implementations, with corresponding test and recording updates.
Changes:
- Reworked managed disk attach/detach logic in
vm/custom.pyto use AAZ commands. - Updated scenario tests and re-recorded HTTP interactions for the new behavior / API versions.
- Added a small
safe_gethelper for nested dict access used by the new detach flow.
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Migrates VM disk attach/detach implementation to AAZ (core behavior change). |
| src/azure-cli/azure/cli/command_modules/vm/_vm_utils.py | Adds safe_get helper for nested dict access used by new logic. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Updates VM scenario tests to reflect new behavior and VM create parameters. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_ultra_ssd_storage_sku.yaml | Updates recordings for new compute API version. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_disk_storage_sku.yaml | Updates recordings for new compute API version. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_disk_attach_from_copy_and_restore.yaml | Updates recordings for new compute API version. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_disk_attach_detach_api.yaml | Updates recordings for new compute API version. |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/vm/custom.py:2468
AttachDetachDataDiskexpects snake_case element fields (disk_id,detach_option) but this list usesdiskId/detachOption, which will likely be ignored and violate the requireddisk_idfield. Also, this branch doesn't forward theno_waitparameter to the AAZ command. Use the AAZ arg names and includeno_waitincommand_args.
for disk_item in disk_ids:
disk = {'diskId': disk_item, 'detachOption': 'ForceDetach' if force_detach else None}
data_disks.append(disk)
result = AttachDetachDataDisk(cli_ctx=cmd.cli_ctx)(command_args={
'vm_name': vm_name,
'resource_group': resource_group_name,
'data_disks_to_detach': data_disks
})
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm disk attachaz vm disk detachDescription
Migrate
az vm disk attachandaz vm disk detachcommands from hand written sdk to aaz.Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.