Replace child_process.exec() with execFile()#288
Merged
mikeharder merged 19 commits intoAzure:mainfrom Mar 24, 2026
Merged
Conversation
mikeharder
commented
Mar 24, 2026
mikeharder
commented
Mar 24, 2026
- align with specs repo convention
mikeharder
commented
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Avocado’s command execution helper and its usage sites to prefer child_process.execFile() over exec(), aiming to avoid shell-string execution and improve argument handling.
Changes:
- Replace the internal child-process wrapper from
exec()toexecFile()and update call sites (git runner + test). - Bump package version to
0.10.6and add acheckscript to run build/test/lint/format checks. - Document the change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/child-process-test.ts | Updates test to call execFile('node', [...]) instead of executing a shell command string. |
| src/git.ts | Switches git invocation to execFile('git', [cmd, ...args], options) to avoid shell string construction. |
| src/child-process.ts | Replaces the promisified exec wrapper with an execFile wrapper (still enforcing maxBuffer: Infinity). |
| package.json | Bumps version and adds a check script to run common validation tasks. |
| CHANGELOG.md | Adds a 0.10.6 entry describing the migration to execFile(). |
This reverts commit 40fb8df.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mikeharder
commented
Mar 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mikeharder
commented
Mar 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mikeharder
commented
Mar 24, 2026
mikeharder
commented
Mar 24, 2026
mikeharder
commented
Mar 24, 2026
mikeharder
commented
Mar 24, 2026
danieljurek
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.