Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the Scaling metrics row layout to behave better under high zoom and narrow widths, addressing reported accessibility/layout issues in the Scaling UI.
Changes:
- Replaced the MUI
Grid-based metric layout with a wrapping flex layout. - Switched metric tile sizing to
rem-based minimum widths/flex-basis to avoid overlap at high zoom. - Prevented the Scaling Mode icon from shrinking out of view via
flexShrink: 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/Scaling/components/ScalingMetrics.tsx
Show resolved
Hide resolved
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com> change
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix two accessibility issues in the scaling metrics row: metric tiles now use
rem-based widths so columns scale correctly at high zoom without overlapping, and the scaling mode icon usesflexShrink: 0to prevent it from being squeezed out of view on resize.Fixes: #541, #542