Skip to content

InfoTab: Extract shared components and update UI#539

Open
skoeva wants to merge 3 commits intoAzure:mainfrom
skoeva:infotab2
Open

InfoTab: Extract shared components and update UI#539
skoeva wants to merge 3 commits intoAzure:mainfrom
skoeva:infotab2

Conversation

@skoeva
Copy link
Copy Markdown
Collaborator

@skoeva skoeva commented Mar 26, 2026

These changes extract shared components from CreateAKSProject and update the InfoTab UI.

Changes

  • Move NetworkingStep, ComputeStep, FormField, ResourceCard to shared/ and update all import sites (CreateAKSProject, CreateNamespace, InfoTab, stories, guidepup test)
  • Place ingress and egress selectors side-by-side in NetworkingStep using a Grid layout, matching the CPU/memory pairs in ComputeStep
  • Replace the Card/CardContent wrapper in InfoTab with a plain Box with padding, consistent with the Scaling and Metrics tabs
image

@skoeva skoeva self-assigned this Mar 26, 2026
@skoeva skoeva marked this pull request as ready for review March 26, 2026 19:43
Copilot AI review requested due to automatic review settings March 26, 2026 19:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the AKS Desktop plugin UI by extracting wizard step components into components/shared/ and reusing them in multiple flows, while also aligning the InfoTab layout with other tabs.

Changes:

  • Moved/reused NetworkingStep, ComputeStep, FormField, and ResourceCard from CreateAKSProject into components/shared/, updating import sites (CreateAKSProject, CreateNamespace, InfoTab, stories, and Guidepup tests).
  • Updated NetworkingStep to place ingress/egress selectors side-by-side using an MUI Grid layout.
  • Replaced InfoTab’s Card/CardContent wrapper with a padded Box for consistency with other tabs.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
plugins/aks-desktop/src/components/shared/ResourceCard.tsx Updates prop type import path after extraction/reuse.
plugins/aks-desktop/src/components/shared/FormField.tsx Updates prop type import path after extraction/reuse.
plugins/aks-desktop/src/components/shared/ComputeStep.tsx Updates prop type import path after extraction/reuse.
plugins/aks-desktop/src/components/shared/NetworkingStep.tsx New shared NetworkingStep with Grid-based side-by-side selects.
plugins/aks-desktop/src/components/InfoTab/InfoTab.tsx Switches wrapper from Card to padded Box; uses shared steps.
plugins/aks-desktop/src/components/CreateNamespace/CreateNamespace.tsx Uses shared FormField import.
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx Uses shared ComputeStep/NetworkingStep imports.
plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx Uses shared FormField import.
plugins/aks-desktop/src/components/CreateAKSProject/components/NetworkingStep.tsx Removes the old in-feature NetworkingStep implementation.
plugins/aks-desktop/src/components/CreateAKSProject/components/Step.stories.tsx Updates stories to import shared components.
plugins/aks-desktop/src/components/CreateAKSProject/components/CreateAKSProjectPure.guidepup.test.tsx Updates test imports to use shared components.
Comments suppressed due to low confidence (1)

plugins/aks-desktop/src/components/shared/FormField.tsx:7

  • FormField is now under components/shared/ but its props type is imported from CreateAKSProject/types, which couples a shared UI primitive to the CreateAKSProject feature module. Consider defining/exporting FormFieldProps from shared/FormField itself (or a shared/types module) and updating CreateAKSProject to consume/re-export it, so other flows (e.g. CreateNamespace) don’t depend on CreateAKSProject types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 26, 2026 20:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

plugins/aks-desktop/src/components/shared/ComputeStep.tsx:10

  • components/shared/ComputeStep imports ComputeStepProps from CreateAKSProject/types, which means this shared component can’t be reused without depending on the CreateAKSProject module. Consider defining the props type locally (or moving the relevant step prop types into a shared types module) so shared/ stays decoupled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

skoeva added 3 commits March 26, 2026 16:16
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants