Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared useAsync<T> React hook for standardizing async data/loading/error state handling with stale-request cancellation, and migrates a couple of existing hooks to validate the approach.
Changes:
- Added generic
useAsynchook with request-id-based stale request cancellation andreset(). - Added dedicated unit tests for
useAsync(success, error, cancellation, args passthrough, reset, unmount behavior). - Refactored
useChartDataandusePipelineRunsto useuseAsyncand remove bespoke cancellation/boilerplate.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plugins/aks-desktop/src/hooks/useAsync.ts | New shared async state hook with cancellation + reset. |
| plugins/aks-desktop/src/hooks/useAsync.test.ts | Unit tests validating useAsync behavior. |
| plugins/aks-desktop/src/components/Scaling/hooks/useChartData.ts | Migrates chart data fetching/caching hook to useAsync. |
| plugins/aks-desktop/src/components/Deployments/hooks/usePipelineRuns.ts | Migrates GitHub pipeline runs hook to useAsync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/Scaling/hooks/useChartData.ts
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/Deployments/hooks/usePipelineRuns.ts
Outdated
Show resolved
Hide resolved
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
4b91cbb to
3f2841c
Compare
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
3f2841c to
f40e9bb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/Deployments/hooks/usePipelineRuns.ts
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/Scaling/hooks/useChartData.ts
Outdated
Show resolved
Hide resolved
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
f40e9bb to
aab9ed4
Compare
Provides a reusable hook that handles loading, error, and data state for async operations with race-condition protection and unmount safety. Supports both immediate (run on mount) and deferred (manual execute) modes with type-safe overloads.
Replaces hand-rolled loading/error/staleness logic with useAsync, removing ~60 lines of boilerplate while preserving caching and Prometheus query behavior.
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
aab9ed4 to
4d0ccda
Compare
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
4d0ccda to
1965ca9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replaces manual signal-based cancellation and state management with useAsync, simplifying the hook while preserving partial-failure handling and sorted/truncated results.
gambtho
force-pushed
the
thgamble/use-async-hook
branch
from
1965ca9 to
1391ffb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #533
useAsync<T>hook (src/hooks/useAsync.ts) that encapsulates the loading/error/datauseStatepattern with built-in request-ID-based cancellation, used by 12+ hooks across the codebaseuseChartDataandusePipelineRunsas proof-of-concept consumers, reducing boilerplate by ~90 linesDetails
The hook provides:
data,loading,errorstate managementexecute(...args)for manual triggeringreset()to clear stateTest plan
npm run tscpasses (pre-existing guidepup module errors only)npm test -- --runpasses (pre-existing failures only)npx vitest run src/hooks/useAsync.test.ts— 7/7 tests pass