fix: add missing getSubscriptions mock in ImportAKSProjects test#522
Open
fix: add missing getSubscriptions mock in ImportAKSProjects test#522
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Vitest failure in the AKS Desktop ImportAKSProjects test suite by updating the ../../utils/azure/aks module mock to include the newly imported getSubscriptions export.
Changes:
- Add a
mockGetSubscriptionsfunction and expose it via thevi.mock('../../utils/azure/aks', ...)factory. - Reset and re-seed the
getSubscriptionsmock return value inbeforeEachto keep tests isolated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.test.tsx
Outdated
Show resolved
Hide resolved
sniok
previously approved these changes
Mar 25, 2026
gambtho
force-pushed
the
thgmable/mainfix
branch
from
4029663 to
cbb0c58
Compare
gambtho
force-pushed
the
thgmable/mainfix
branch
from
cbb0c58 to
5b5c438
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit a5ad940 added getSubscriptions to the component's imports
but did not update the vi.mock for ../../utils/azure/aks, causing
vitest to throw "No getSubscriptions export is defined on the mock".