Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Git attributes configuration to prevent Git from converting shell scripts to CRLF on Windows checkouts (e.g., when core.autocrlf=true), addressing the bash failure reported in #520 during npm run plugin:setup.
Changes:
- Add a
.gitattributesrule to force LF (eol=lf) for*.shfiles.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a
.gitattributesfile to ensure.shfiles are always checked out with LF line endings, preventingcore.autocrlf=trueon Windows from converting them to CRLF. This fixes a build failure where bash would rejectset -o pipefail\ras an invalid option.Fixes: #520
Testing
npm run plugin:setupon Windows and ensure it doesn't fail