Skip to content

Adding support for GHAS + Minor improvements#311

Open
joselcaguilar wants to merge 25 commits intoAzure:mainfrom
josunefoOrg:main
Open

Adding support for GHAS + Minor improvements#311
joselcaguilar wants to merge 25 commits intoAzure:mainfrom
josunefoOrg:main

Conversation

@joselcaguilar
Copy link
Copy Markdown

Changes in collaboration with @josunefon

  • Adding support for GHAS (repos)
  • Using OIDC Azure authentication in GitHub workflow .github/workflows/gh-contributions.yml with federated credentials
  • Breaking change: Base name and Storage Account name changed in dashboards/GitHubDashboard-Contributors/infrastructure/deploy.bicep to adapt naming with the new features added related to GHAS

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I've tested the solution locally without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

@joselcaguilar joselcaguilar requested a review from a team as a code owner May 10, 2023 07:45
@joselcaguilar
Copy link
Copy Markdown
Author

Hi @Azure/cco-maintainers, I'm just sending a kindly reminder to review the PR please. Thanks in advance! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants