fix(gpu): tear down cuda-lts VHD prebake on GRID nodes before managed…#8925
Closed
awesomenix wants to merge 3 commits into
Closed
fix(gpu): tear down cuda-lts VHD prebake on GRID nodes before managed…#8925awesomenix wants to merge 3 commits into
awesomenix wants to merge 3 commits into
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
…cts/aks-node-controller-hotfix.json
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a GPU provisioning failure on Ubuntu GRID / converged A10 (NVv5) nodes booting from CUDA-prebaked shared VHDs by tearing down a mismatched CUDA prebake before a GRID driver install path runs, preventing NVML “driver/library version mismatch”.
Changes:
- Added
cleanUpGridNodeCudaPrebakeincse_config.shand invoked it early inensureGPUDrivers(Ubuntu-only) to remove CUDA prebake when the node’s driver type maps to GRID. - Added ShellSpec coverage for
cleanUpGridNodeCudaPrebakedecision logic incse_config_spec.sh.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/cse_config.sh | Adds GRID-vs-CUDA prebake teardown logic and calls it before GPU driver dispatch. |
| spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh | Adds ShellSpec tests validating teardown vs no-op behavior across marker/node-kind combinations. |
| # GRID and a prebake marker exists. Reuses cleanUpPrebakedGPUDriver (from cse_install_ubuntu.sh) for | ||
| # the actual removal. NAP/agentpool cuda nodes are intentionally untouched here. | ||
| cleanUpGridNodeCudaPrebake() { | ||
| [ "$OS" = "$UBUNTU_OS_NAME" ] || return 0 |
Comment on lines
+1362
to
+1364
| if [ "$OS" = "$UBUNTU_OS_NAME" ]; then | ||
| logs_to_events "AKS.CSE.ensureGPUDrivers.cleanUpGridNodeCudaPrebake" cleanUpGridNodeCudaPrebake || exit $ERR_GPU_DRIVERS_START_FAIL | ||
| fi |
Contributor
Author
|
hotfixing works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… install (#8919)
testing cherry-pick
DO NOT MERGE