fix(renovate): correct ama-metrics version parsing#8920
Merged
Conversation
Renovate's ama-metrics regex did not capture a named major group, which caused incorrect ordering (e.g., 6.27.0 ranked above 7.x). Update the rule to parse ama-metrics tags explicitly, including optional variant suffixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Devinwong
requested review from
AbelHu,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Renovate configuration to correctly parse and compare ama-metrics image tags so Renovate stops proposing “downgrade” PRs when moving between major versions (e.g., 6.x → 7.x).
Changes:
- Updates the
versioningregex forazuremonitor/containerinsights/ciprod/prometheus-collector/imagesto include a namedmajorgroup. - Tightens the parsing to the expected tag format (
<major>.<minor>.<patch>-main-<dd-mm-yyyy>-<sha>) with an optional known suffix (cfg|targetallocator|ccp|win).
awesomenix
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Two-commit fix for the ama-metrics Renovate rule:
Commit 1 — added named
majorgroup to fix the6.27.0 > 7.0.0mis-ordering that caused a downgrade PR (#8897).Commit 2 — removed the named
prereleasegroup introduced in commit 1. Having aprereleasegroup causes Renovate to mark all ama-metrics tags as unstable and skip them entirely (no updates detected).The final regex:
major/minor/patch→ correct version ordering(?:...)→ not treated as prerelease, so tags are considered stablecompatibility→ differentiatescfg,targetallocator,ccp,winvariantsRelated