fix: start at boot and wait for network online target in cse_cmd.sh#8911
fix: start at boot and wait for network online target in cse_cmd.sh#8911awesomenix wants to merge 1 commit into
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce node boot/provisioning latency by removing the aks-node-controller.service dependency on network-online.target (so the unit can be started earlier/in parallel) and instead waiting for network readiness within the provisioning command script (cse_cmd.sh) and (selectively) in the ANC wrapper when hotfix download paths are used.
Changes:
- Make
aks-node-controller.servicea static unit (no[Install]section) and removeAfter=/Wants=fornetwork-online.target. - Add
network-online.targetwait logic tocse_cmd.sh(and the corresponding ANC template), plus conditional waits inaks-node-controller-wrapper.shbefore hotfix network operations. - Update VHD build and validation scripts to keep the ANC unit disabled/static and validate the new state.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/test/linux-vhd-content-test.sh |
Updates VHD validation to require ANC unit to be static. |
vhdbuilder/packer/pre-install-dependencies.sh |
Disables ANC service during VHD build to keep it from running before provisioning artifacts exist. |
parts/linux/cloud-init/artifacts/cse_cmd.sh |
Adds an explicit wait for network-online.target before running provisioning. |
parts/linux/cloud-init/artifacts/aks-node-controller.service |
Removes network-online.target ordering and makes the unit static. |
parts/linux/cloud-init/artifacts/aks-node-controller-wrapper.sh |
Adds conditional network-online waits for hotfix-related operations. |
aks-node-controller/parser/templates/cse_cmd.sh.gtpl |
Keeps the generated cse_cmd.sh template in sync with the new network-online wait behavior. |
| RemainAfterExit=yes | ||
|
|
||
| [Install] | ||
| WantedBy=basic.target |
There was a problem hiding this comment.
you probably were aware of this too
🔴 High Risk — 🏗️ Architecture / Backward Compatibility
parts/linux/cloud-init/artifacts/aks-node-controller.service removes [Install] and WantedBy, and vhdbuilder/packer/pre-install-dependencies.sh now disables the unit. That drops the long-standing boot fallback path (service auto-start) and makes provisioning depend entirely on boothook start timing.
This aligns with the failing PR E2E signal: multiple scenarios are stuck in provision-wait loop ([ -f /opt/azure/containers/provision.complete ]) and never reach expected CSE output (ADO build 172002687, Run AgentBaker E2E).
Mitigation: restore a fallback start path (or equivalent robust trigger) so ANC still starts when boothook path misses/races.
awesomenix
force-pushed
the
nishp/anc/dontwaitnetwork
branch
from
ff8ad6a to
0a50baa
Compare
| exit ${cloudInitExitCode}; | ||
| fi; | ||
| {{end}} | ||
| timeout 60 sh -c 'until systemctl is-active --quiet network-online.target; do sleep 0.1; done' || exit 124 |
| @@ -1,4 +1,5 @@ | |||
| echo $(date),$(hostname) > ${PROVISION_OUTPUT}; | |||
| timeout 60 sh -c 'until systemctl is-active --quiet network-online.target; do sleep 0.1; done' || exit 124 | |||
| wait_for_network_online() { | ||
| echo "Waiting for network-online.target at $(date -Ins)" | ||
|
|
||
| if timeout 30 sh -c 'until systemctl is-active --quiet network-online.target; do sleep 0.1; done'; then | ||
| echo "network-online.target reached at $(date -Ins)" | ||
| else | ||
| echo "Timed out waiting for network-online.target at $(date -Ins)" >&2 | ||
| return 1 | ||
| fi | ||
| } |
dont wait for network-online.target start in parallel, this saves about 4s