Skip to content

chore: update PR template #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameronmeissner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update PR template #7569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 1 addition & 49 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,57 +1,9 @@
**What type of PR is this?**

<!--
Add one of the following kinds:
/kind bug
/kind test
/kind cleanup
/kind documentation
/kind feature
/kind design
Optionally add one or more of the following kinds if applicable:
/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Copy link
Collaborator

@djsly djsly Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what shioudl we be putting in here ? we don't really have github issue...

<!--
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Requirements**:

- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/)
Copy link
Contributor

@awesomenix awesomenix Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there is a PR lint check which forces you to have this in PR title (which is mostly derived from commit message)

<!-- Common commit types:
build: Build 🏭
chore: Maintenance 🔧
ci: Continuous Integration 💜
docs: Documentation 📘
feat: Features 🌈
fix: Bug Fixes 🐞
perf: Performance Improvements 🚀
refactor: Code Refactoring 💎
revert: Revert Change ◀️
style: Code Style 🎶
security: Security Fix 🛡️
test: Testing 💚 -->
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
- [ ] commits are GPG signed and Github marks them as verified
Copy link
Collaborator

@djsly djsly Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this here with a URL to the readme we have in the repo ?


**Special notes for your reviewer**:

**Release note**:

```
none
```
Loading