-
Notifications
You must be signed in to change notification settings - Fork 240
chore(deps): update dependencies - use aks-localdns package for localdns binary - DO NOT REVIEW #7514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "v3.0": { | ||
| "versionsV2": [ | ||
| { | ||
| "renovateTag": "OCI_registry=upstream.azurecr.io, name=oss/v2/packages/localdns/aks-localdns", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upstream agreed to let you publish aks-localdns under general OSS? they didn't let me publish aks-secure-tls-bootstrap-client...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I updated the title to - DO NOT REVIEW. I am working on POC and no review is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found your PR: https://github.com/Azure/dalec-build-defs/pull/2976 - I guess this more OSS-"friendly" since you're sourcing from the coredns upstream repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the dalec PR to publish the package is draft and has not been review by dalec team yet. I was skeptical about aks-localdns. I will change the code later here accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a dalec spec with kubernetes-coredns already in dalec repo, so need to figure out alternative naming convention for this.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: