Skip to content

Conversation

@SriHarsha001
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version
  • commits are GPG signed and Github marks them as verified

Special notes for your reviewer:

Release note:

none

@github-actions github-actions bot added the components This pull request updates cached components on Linux or Windows VHDs label Dec 10, 2025
@SriHarsha001 SriHarsha001 changed the title use aks-localdns package for localdns binary chore(deps): update dependencie - use aks-localdns package for localdns binary Dec 10, 2025
@SriHarsha001 SriHarsha001 changed the title chore(deps): update dependencie - use aks-localdns package for localdns binary chore(deps): update dependencies - use aks-localdns package for localdns binary Dec 10, 2025
"v3.0": {
"versionsV2": [
{
"renovateTag": "OCI_registry=upstream.azurecr.io, name=oss/v2/packages/localdns/aks-localdns",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream agreed to let you publish aks-localdns under general OSS? they didn't let me publish aks-secure-tls-bootstrap-client...

Copy link
Contributor Author

@SriHarsha001 SriHarsha001 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I updated the title to - DO NOT REVIEW. I am working on POC and no review is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found your PR: https://github.com/Azure/dalec-build-defs/pull/2976 - I guess this more OSS-"friendly" since you're sourcing from the coredns upstream repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the dalec PR to publish the package is draft and has not been review by dalec team yet. I was skeptical about aks-localdns. I will change the code later here accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a dalec spec with kubernetes-coredns already in dalec repo, so need to figure out alternative naming convention for this.

@SriHarsha001 SriHarsha001 changed the title chore(deps): update dependencies - use aks-localdns package for localdns binary chore(deps): update dependencies - use aks-localdns package for localdns binary - DO NOT REVIEW Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components This pull request updates cached components on Linux or Windows VHDs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants