feat: enable Artifact Streaming on Flatcar #7425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
e5850e9 to
aa6de29
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
aa6de29 to
154b46c
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
154b46c to
3fcc733
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
3fcc733 to
6b656a9
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
6b656a9 to
34e6f00
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
34e6f00 to
4ef58f9
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
4ef58f9 to
b142fe7
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
b142fe7 to
12be550
Compare
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
12be550 to
6bdcf78
Compare
Contributor
Author
|
It took a long time, but I was finally able to test this under RP. I couldn't see any details, but after removing Flatcar's exclusion of the ArtifactStreaming test, I saw that it passed along with the other E2Ev3 tests. |
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
6bdcf78 to
8f1d9c4
Compare
Contributor
Author
|
To be extra sure, I also ran E2Ev3 without this change and saw that |
chewi
requested review from
Devinwong,
cameronmeissner,
ganeshkumarashok and
juan-lee
as code owners
chewi
requested review from
AbelHu,
awesomenix,
djsly,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This uses Flatcar's own systemd system extension for overlaybd and Azure Linux's RPM for acr and the configuration scripts. It's not perfect, but we cannot improve on this until acr changes its build process or goes open source. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/flatcar-artifact-streaming
branch
from
8f1d9c4 to
4f8be1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Artifact Streaming is an important feature for Flatcar.
This uses Flatcar's own systemd system extension for overlaybd and Azure Linux's RPM for acr and the configuration scripts. It's not perfect, but we cannot improve on this until acr changes its build process or goes open source.
Which issue(s) this PR fixes:
Fixes Flatcar for AKS work item #34435545
Requirements:
Release note: