define CS provision shard maestro config as structured yaml and remove unneeded attribute #3703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change the maestro config definition within the provision shard configuration as fully structured yaml. Before it was an inline json which was more error prone. This change is possible because we rolled out a new change in CS that allows defining the maestro configuration of the provision shard as structured yaml instead of as inline json as an alternative.
…config That attribute represented the K8s Namespace where ACM expects ManifestWorks to be created in the Management Cluster. That name was confusing because it could be confused with an Azure AKS Management Cluster Resource ID. In CS we renamed the attribute to `management_cluster_acm_manifestworks_k8s_namespace`, we also default it to `local-cluster` and we also limit the set of accepted values to that one. We remove the setting of the `management_cluster_id` attribute because of the mentioned reasons above. This will default that K8s Namespace to `local-cluster` which means no change in behavior should occur with this change.
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janboll, miguelsorianod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
openshift-merge-bot
bot
deleted the
msoriano-cspshard-configchanges-20250105-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the maestro config definition within the provision
shard configuration as fully structured yaml. Before it was
an inline json which was more error prone.
This change is possible because we rolled out a new change in CS
that allows defining the maestro configuration of the provision
shard as structured yaml instead of as inline json as an alternative.
Additionally, we remove the management_cluster_id attribute from CS provision shard config.
That attribute represented the K8s Namespace where ACM expects
ManifestWorks to be created in the Management Cluster. That name was
confusing because it could be confused with an Azure AKS Management Cluster
Resource ID.
In CS we renamed the attribute to
management_cluster_acm_manifestworks_k8s_namespace, we also defaultit to
local-clusterand we also limit the set of accepted values tothat one.
We remove the setting of the
management_cluster_idattribute becauseof the mentioned reasons above. This will default that K8s Namespace
to
local-clusterwhich means no change in behavior should occur withthis change.