Skip to content

Fix Kusto output#3702

Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom
fix-kusto-output
Jan 6, 2026
Merged

Fix Kusto output#3702
openshift-merge-bot[bot] merged 1 commit intomainfrom
fix-kusto-output

Conversation

@janboll
Copy link
Copy Markdown
Collaborator

@janboll janboll commented Jan 5, 2026

AROSLSRE-245

What

Use arobit toggle and not manage instance toggle for output.

Why

This fixes the conditional kusto deployment. The output should only expect the kusto to be there if we actually want to use it (enable arobit output). The manageinstance flag is there to check if we actually want to deploy kusto.

Special notes for your reviewer

This fixes the conditional kusto deployment.
@janboll
Copy link
Copy Markdown
Collaborator Author

janboll commented Jan 5, 2026

/test frontend-simulation

@janboll
Copy link
Copy Markdown
Collaborator Author

janboll commented Jan 5, 2026

/retest-required

param kustoName = '{{ .kusto.kustoName }}'

param manageInstance = {{ .kusto.manageInstance }}
param kustoEnabled = {{ .arobit.kusto.enabled }}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual fix, rest is just renaming parameter for clarity

@venkateshsredhat
Copy link
Copy Markdown
Collaborator

/lgtm

@venkateshsredhat
Copy link
Copy Markdown
Collaborator

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janboll, venkateshsredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8839990 into main Jan 6, 2026
22 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the fix-kusto-output branch January 6, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants