Conversation
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@raelga: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fixed in the latest release. |
This pull request adds automation for including critical OCM addon CRDs in the multicluster-engine Helm charts, updates documentation to explain this new process, and bumps several image and chart versions. The most significant change is the introduction of a script that fetches required CRDs from the upstream open-cluster-management-io/api repository, ensuring that all necessary CRDs are present even though they're not shipped in the main MCE operator bundle.
Automation and CRD Management
add-ocm-crds.shthat automatically downloads and adds the OCM addon CRDs (ManagedClusterAddOn, ClusterManagementAddOn, AddOnDeploymentConfig) from the upstream open-cluster-management-io/api repository to the Helm chart, ensuring required CRDs are always present. (acm/add-ocm-crds.sh,acm/Makefile,acm/deploy/helm/multicluster-engine-crds/templates/addondeploymentconfigs.addon.open-cluster-management.io.customresourcedefinition.yaml) [1] [2] [3]Documentation Improvements
README.mdto document the new automated process for adding OCM addon CRDs and explain why this is necessary for the MCE operator and policy components.Version and Image Updates
multicluster-engine-crdsHelm chart and app versions and updated the referenced MCE operator bundle image digest to the latest version. (acm/deploy/helm/multicluster-engine-crds/Chart.yaml)values.yamlto newer versions for improved reliability and security. (acm/deploy/helm/multicluster-engine-config/charts/policy/values.yaml)