removing non azure offering flavour id - osd

[mahesh-palkar]

https://issues.redhat.com/browse/ARO-20748

What

Code changes to remove all identified non-Azure offering names (osd-4) throughout the ARO HCP system.
Investigation results are documented with this issue : https://issues.redhat.com/browse/ARO-23124

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mahesh-palkar
Once this PR has been reviewed and has the lgtm label, please assign roivaz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[miguelsorianod]

Have we analyzed the consequences of removing that on CS side? internally, if I recall correctly, the flavor is used at the least to set some defaults.
This shouldn't be further progressed until more detail is provided showcasing on what is flavor used for and what are the implications of removing it, for both new and preexisting clusters/resources.

[zgalor]

Have we analyzed the consequences of removing that on CS side? internally, if I recall correctly, the flavor is used at the least to set some defaults. This shouldn't be further progressed until more detail is provided showcasing on what is flavor used for and what are the implications of removing it, for both new and preexisting clusters/resources.

We can further discuss if removing it on the CS side is required. However it's irrelevant for this PR, which removes the 'osd4' flavour from being called explicitly in the test, where it is the default anyway.
Removing this call from the test will remove the only reference to non-Azure managed OpenShift offering on this open-source repo - which is what we eventually want

[zgalor]

@mahesh-palkar to verify this fix try creating a cluster locally, via the RP and see that it works

[patilsuraj767]

@miguelsorianod @zgalor Could you please do another round of review? I have rebased this PR.
We do not need explicitly pass the flavour property to CS, CS defaults it to osd-4.

[zgalor]

LGTM
We need approval from 1p team
@bennerv @mbarnes-azure PTAL

[patilsuraj767]

/test e2e-parallel

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@mahesh-palkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/cspr	3900846	link	true	/test cspr
ci/prow/images-push	3900846	link	true	/test images-push

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[raelga]

@mahesh-palkar This PR needs a rebase.