Skip to content

Add more approvers for RP code directories#3656

Closed
mbarnes wants to merge 1 commit intomainfrom
add-approvers-for-1p
Closed

Add more approvers for RP code directories#3656
mbarnes wants to merge 1 commit intomainfrom
add-approvers-for-1p

Conversation

@mbarnes
Copy link
Copy Markdown
Collaborator

@mbarnes mbarnes commented Dec 18, 2025

Also remove Maitiu Ciarain (mociarain) who is no longer on ARO-HCP.

@openshift-ci openshift-ci Bot requested review from deads2k and geoberle December 18, 2025 13:10
@geoberle
Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoberle, mbarnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SudoBrendan
Copy link
Copy Markdown
Collaborator

/test e2e-parallel

@stevekuznetsov
Copy link
Copy Markdown
Contributor

/hold

For the same reasons articulated in #3599 (comment)

- Tanmay Satam (tsatam)
- Rajdeep Chauhan (rajdeepc2792)

Also remove Maitiu Ciarain (mociarain) who is no longer on ARO-HCP.
@mbarnes mbarnes force-pushed the add-approvers-for-1p branch from 8d04e0b to 3bf87f3 Compare December 18, 2025 16:53
@openshift-ci openshift-ci Bot removed the lgtm label Dec 18, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 18, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 18, 2026

@mbarnes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-images 3bf87f3 link true /test periodic-images
ci/prow/e2e-parallel 3bf87f3 link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mbarnes mbarnes closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants