README: move 'Make it yours' before 'Clean up'#13
Closed
paulyuk wants to merge 1 commit into
Closed
Conversation
Customize-before-teardown reads more naturally. Promotes 'Make it yours' into step 6 of the Quickstart, with 'Clean up' as the closing step 7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 16, 2026
Member
Author
|
Consolidated into a single PR per author preference: https://github.com/Azure-Samples/m365-inbox-serverless-agent-python/pull/(see latest) |
paulyuk
added a commit
that referenced
this pull request
Jun 17, 2026
* Fix hydrate-local-settings next-step hint to match README workflow The script printed 'Run func start to start the host', which is incomplete and skips the actual local-run workflow documented in the README: azurite --silent --skipApiVersionCheck --location .azurite # terminal A uv run func start # terminal B uv run python chat.py # terminal C Updated both the bash and PowerShell variants to print the three-terminal block so users land on the working path without re-reading the README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * README: move 'Make it yours' before 'Clean up' Customize-before-teardown reads more naturally. Promotes 'Make it yours' into step 6 of the Quickstart, with 'Clean up' as the closing step 7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * README: add 'Go live' step before deploy Sets MAILBOX_OWNER_EMAIL (required for LIVE mail) and the optional TEAMS_TEAM_ID / TEAMS_CHANNEL_ID before `azd up`, so the deployed agents are LIVE on first deploy instead of starting in DRY RUN with placeholder values. Renumbers the trailing Quickstart steps. Stacks on top of #13 (Make it yours before Clean up). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * azure.yaml: hydrate local.settings.json in postdeploy Chain hydrate-local-settings before configure-trigger so 'azd up' / 'azd provision' keeps both the deployed Function App app settings AND local.settings.json in sync from the same source of truth (azd env). Today, 'azd env set MAILBOX_OWNER_EMAIL ...' followed by 'azd provision' pushes the new value to the deployed app but leaves local.settings.json stale — the local chat client then reports 'Partial: placeholder' even though the deployed app is correctly LIVE. Stacks on #15. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat.py: probe Functions host in doctor + use-cloud-host helper The 'Show config readiness' doctor only inspected env vars; if the local Functions host wasn't running, you'd only learn that when an agent call failed with a generic 'Connection refused'. And there was no documented way to point chat.py at the deployed cloud Function App. This adds: * `infra/scripts/use-cloud-host.{sh,ps1}` — sourceable helpers that export AGENT_URL + FUNCTION_KEY from `azd env` + `az functionapp keys list`, so the chat client hits the deployed Function App in Azure without running azurite + func start locally. * Doctor (option 4) shows a new 'Functions host' row up top with 🟢/🔴 + which host (local vs cloud) is being targeted and whether it's reachable. * When a chat call fails with a connection error, the hint now spells out BOTH paths: the 3-terminal local setup AND the one-liner to switch to the deployed cloud host. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * README: lead with Daily Briefing in 'What it does for you' Daily Briefing is the most concrete, demo-able value of the agent — it's what people see on day one once they've deployed. Lead with it and use the full noun phrase 'Daily Briefing' (matches the menu label in chat.py and the agent name) instead of the verb-form 'Brief'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * README: drop em dashes (use colons in bullet defs, hyphens elsewhere) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reorders the README so 'Make it yours' (customization) comes before 'Clean up' (teardown) in the Quickstart. Promotes both to numbered steps 6 and 7.
Why
Customize-before-teardown is the natural reading order — users want to play with VIP rules and skills before tearing down the deployment, not after. The current order tells them to tear down first and then mentions customization as an afterthought.
Change
##to###so it nests under Quickstart consistently.