Fix hydrate-local-settings next-step hint to match README workflow#12
Closed
paulyuk wants to merge 1 commit into
Closed
Fix hydrate-local-settings next-step hint to match README workflow#12paulyuk wants to merge 1 commit into
paulyuk wants to merge 1 commit into
Conversation
The script printed 'Run func start to start the host', which is incomplete and skips the actual local-run workflow documented in the README: azurite --silent --skipApiVersionCheck --location .azurite # terminal A uv run func start # terminal B uv run python chat.py # terminal C Updated both the bash and PowerShell variants to print the three-terminal block so users land on the working path without re-reading the README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Consolidated into a single PR per author preference: https://github.com/Azure-Samples/m365-inbox-serverless-agent-python/pull/(see latest) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hydrate-local-settings.{sh,ps1}printsRun 'func start' to start the host.as its final line. That's incomplete — the README's actual local-run workflow needs three terminals:Users following the script's hint get stuck — Azurite isn't running (bindings fail with 'No connection could be made'), and bare
func startskips theuv runprefix so Core Tools picks the wrong Python interpreter.Why
Caught while running through a fresh
~/src/m365-test1clone end-to-end post-azd provision. The script tells the user one thing; the README tells them another. The script wins because it's the last thing they saw.Change
Update both the bash and PowerShell variants to echo the three-terminal block verbatim from the README, so users land on the working path without re-reading docs.
Test
bash -n infra/scripts/hydrate-local-settings.shpassesechoblock.