Skip to content

Convert G1 point logging to hexadecimal format #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dimitrolito wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert G1 point logging to hexadecimal format #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions sol/src/honk/utils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,15 @@ function bytes32ToString(bytes32 value) pure returns (string memory result) {

function logG(string memory name, Honk.G1ProofPoint memory p) pure {
Honk.G1Point memory point = convertProofPoint(p);

// TODO: convert both to hex before printing to line up with cpp
string memory x = bytes32ToString(bytes32(point.x));
string memory y = bytes32ToString(bytes32(point.y));

string memory message = string(abi.encodePacked(name, " x: ", x, " y: ", y));
console2.log(message);
console2.log(name, x, y);
}

function logG(string memory name, uint256 i, Honk.G1Point memory point) pure {
// TODO: convert both to hex before printing to line up with cpp
string memory x = bytes32ToString(bytes32(point.x));
string memory y = bytes32ToString(bytes32(point.y));

string memory message = string(abi.encodePacked(" x: ", x, " y: ", y));
console2.log(name, i, message);
console2.log(name, i, x, y);
}

function logUint(string memory name, uint256 value) pure {
Expand Down